-
Notifications
You must be signed in to change notification settings - Fork 140
Initial support for tesla to replace hackney #170
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Conversation
4a8a1c2 to
d8b8081
Compare
|
@scrogson Would love to get your opinion |
|
@yordis What do you think? |
|
@olafura thank you so much for doing this. Looking good so far. Just feedback about the documentation. Hopefully, we can follow up on making the code pretty, it is a bit messy at the moment, but we should make it work first. Please fix the CI pipelining as well. |
43deb56 to
093263a
Compare
|
@yordis Thank you for the review, addressed you comments. |
d3744eb to
7f8fc39
Compare
|
@yordis I changed the default back to Httpc |
c7f2d67 to
8718889
Compare
|
@olafura I love it, Do you mind updating the |
4e616e0 to
3c03699
Compare
There are a lot of http client and a lot of ways of handling requests. Using tesla we can allow users to pick what http client they want and what configurations they want.
3c03699 to
59b9d18
Compare
There are a lot of http client and a lot of ways of handling requests. Using tesla we can allow users to pick what http client they want and what configurations they want.
There are a lot of refactoring opportunities with using tesla but I wanted to try to keep it as simple as possible.