Thanks to visit codestin.com
Credit goes to github.com

Skip to content

Conversation

@olafura
Copy link
Contributor

@olafura olafura commented Nov 15, 2022

There are a lot of http client and a lot of ways of handling requests. Using tesla we can allow users to pick what http client they want and what configurations they want.

There are a lot of refactoring opportunities with using tesla but I wanted to try to keep it as simple as possible.

@olafura olafura force-pushed the olafura/tesla branch 3 times, most recently from 4a8a1c2 to d8b8081 Compare November 17, 2022 14:50
@olafura
Copy link
Contributor Author

olafura commented Nov 18, 2022

@scrogson Would love to get your opinion

@olafura
Copy link
Contributor Author

olafura commented Nov 22, 2022

@yordis What do you think?

@yordis
Copy link
Member

yordis commented Nov 22, 2022

@olafura thank you so much for doing this. Looking good so far. Just feedback about the documentation.

Hopefully, we can follow up on making the code pretty, it is a bit messy at the moment, but we should make it work first. Please fix the CI pipelining as well.

@olafura olafura force-pushed the olafura/tesla branch 2 times, most recently from 43deb56 to 093263a Compare November 23, 2022 21:59
@olafura
Copy link
Contributor Author

olafura commented Nov 23, 2022

@yordis Thank you for the review, addressed you comments.
Regarding the CI I think it was failing because of a missing setting version-type strict as suggested by the error message and I made sure were to add it with this example https://github.com/erlef/setup-beam/blob/b980a5ac9b7316a23ebc16de2bb69b7c3ad731b5/.github/workflows/ubuntu.yml

@olafura olafura force-pushed the olafura/tesla branch 2 times, most recently from d3744eb to 7f8fc39 Compare November 24, 2022 14:08
@olafura
Copy link
Contributor Author

olafura commented Nov 24, 2022

@yordis I changed the default back to Httpc

@olafura olafura force-pushed the olafura/tesla branch 2 times, most recently from c7f2d67 to 8718889 Compare November 29, 2022 16:01
@yordis
Copy link
Member

yordis commented Nov 29, 2022

@olafura I love it,

Do you mind updating the CHANGELOG.md

@olafura olafura force-pushed the olafura/tesla branch 4 times, most recently from 4e616e0 to 3c03699 Compare November 29, 2022 20:39
There are a lot of http client and a lot of ways of handling
requests. Using tesla we can allow users to pick what http
client they want and what configurations they want.
@yordis yordis merged commit c3879b6 into ueberauth:master Jan 2, 2023
@olafura olafura deleted the olafura/tesla branch January 9, 2023 10:39
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants