Thanks to visit codestin.com
Credit goes to github.com

Skip to content

Conversation

MkMayo
Copy link

@MkMayo MkMayo commented Apr 3, 2024

Description

Updated mil_pneumatic_actuator for ROS2

Related Issues

Addresses Issue #1124

Testing

This package utilized packages that are Ros 1 Compatible and needed to be replaced with their Ros 2 equivalent. I am not sure if the packages will solve this completely but the structure should be right. I will need help to test.

Copy link
Member

@cbrxyz cbrxyz left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks!

was not received.
PnuematicActuatorDriverChecksumError: The checksum expected and the checksum
received were not the same def get_port(self, port: int) -> int:
"""
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Quotations are broken



class SimulatedPnuematicActuatorBoard(SimulatedSerial):
class SimulatedPnuematicActuatorBoard(SimulatedSerial, Node):
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Why is this a node now?



class PnuematicActuatorDriver:
class PnuematicActuatorDriver(Node):
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Why is this a node now?

@cbrxyz cbrxyz changed the title Ros2 Migration Maanas Kotha Migrated mil_pneumatic_actuator from ROS1 to ROS2 Dec 29, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants