Thanks to visit codestin.com
Credit goes to github.com

Skip to content

Conversation

Jorge-R08
Copy link

Description

Migrated to ROS2 Navigator/utils/remote_control/navigator_joystick_control & Navigator/utils/remote_control/navigator_emergency_control

Screenshot or Video

ROS 2 migration, no screenshot or videos

Related Issues

Part of the ROS2 migration

- Closes #XXX

Testing

About This PR

  • I have updated documentation related to this change so that future members are aware of the changes I've made.

Copy link
Member

@cbrxyz cbrxyz left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good! Just the time calls need to be fixed

# The controller times out after 15 minutes
if (
rospy.Time.now() - self.last_joy.header.stamp > rospy.Duration(15 * 60)
rclpy.Time.now() - self.last_joy.header.stamp > rclpy.Duration(15 * 60)
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

rclpy.Time.now() is not allowed in ROS 2

else:
joy.header.stamp = (
rospy.Time.now()
rclpy.Time.now()
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Same

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants