Add subscription link support to notification email verification template #573
+63
−9
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
I thought it well be smth like this Two methods at the same time. |
|
I think we should keep both methods upd: The reason why both - some people refuse to click the email's link as a part of their safety/security routine. We don't want to force them to click |
|
Updated, please see new look below. |
|
LGTM, but we can't merge it till UI side is ready |
|
my bad, looks like |
umputun
reviewed
Jan 20, 2020
umputun
approved these changes
Jan 21, 2020
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Address #560, the backend part.
When
NOTIFY_EMAIL_SUBSCRIBE_URLenvironment variable is provided, instead of embedding token to email it will be included as a link.With
SITE=http://127.0.0.1andNOTIFY_EMAIL_SUBSCRIBE_URL=/subscribe?token=, link will look likehttp://127.0.0.1/subscribe?token=<subscription_token>. The token is not escaped and I'll escape it if it will be necessary when the frontend part will be written.After the frontend counterpart will be created,
NOTIFY_EMAIL_SUBSCRIBE_URLdefault should be set to newly created URL location.That's how verification email looks like when subscribe_url is supplied: