add RTL support #1799
Merged
add RTL support #1799
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
paskal
approved these changes
Jul 30, 2024
|
Thanks for approving this! Looks like there's just an issue with the dependencies for the tests to run? |
|
Playwright will be fixed in #1802. |
|
@akellbl4 can you please look into pnpm problem? It's not related to the changes in the PR. |
|
Hmm, sorry did I do something wrong when I did |
|
You did nothing wrong, I think master branch is broken at the moment. |
paskal
approved these changes
Aug 24, 2024
|
@umputun let's merge this one, seems like checks are broken in master: we will deal with them later. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This pull request adds support for RTL (right-to-left) languages. By adding
dir=autoto the relevant inputs, divs and textareas you get automatic support of RTL languages, with no detriment or loss in functionality to LTR languages.See this excellent summary PSA: Add dir="auto" to your inputs and textareas.
Before:
After: