Limit max size of the URL #211
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
as go loads the request to memory, it is necessary to prevent huge urls to hit is hard. Checking RawQuery len to the same maxSize in practice may allow double-sized requests max, but will do for now
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
I have seen a case where the GET parameter was insanely large. The current implementation of the
maxReqSizeHandlerdoes not check the URL's length (with all the arguments). This PR addresses this issue.Note: it doesn't check the cumulative size of the request body and URL but rather applies the maximum limit to each one separately.
At the same time, Go was bumped to 1.23 and dependencies updated.