Thanks to visit codestin.com
Credit goes to github.com

Skip to content

fix(copy): align behavior of shallow copy with object spread #26

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 1 commit into from
Dec 25, 2023
Merged

fix(copy): align behavior of shallow copy with object spread #26

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
9 changes: 8 additions & 1 deletion src/utils/copy.ts
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -22,6 +22,8 @@ function strictCopy(target: any) {
return Object.create(Object.getPrototypeOf(target), descriptors);
}

const propIsEnum = Object.prototype.propertyIsEnumerable;

export function shallowCopy(original: any, options?: Options<any, any>) {
let markResult: any;
if (Array.isArray(original)) {
Expand Down Expand Up @@ -55,7 +57,12 @@ export function shallowCopy(original: any, options?: Options<any, any>) {
// don't use `Object.create(Object.getPrototypeOf(obj), Object.getOwnPropertyDescriptors(obj));` by default.
const copy: Record<string | symbol, any> = {};
Object.keys(original).forEach((key) => {
copy![key] = original[key];
copy[key] = original[key];
});
Object.getOwnPropertySymbols(original).forEach((key) => {
if (propIsEnum.call(original, key)) {
copy[key] = original[key];
}
});
return copy;
} else {
Expand Down
6 changes: 2 additions & 4 deletions test/immer/__tests__/base.ts
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -909,13 +909,11 @@ function runBaseTest(name, autoFreeze, useStrictShallowCopy, useListener) {
const test = Symbol('test');
const baseState = { [test]: true };
const nextState = produce(baseState, (s) => {
// !!! This is different from immer
// expect(s[test]).toBeTruthy();
expect(s[test]).toBeTruthy();
s.foo = true;
});
// !!! This is different from immer
expect(nextState).toEqual({
// [test]: true,
[test]: true,
foo: true,
});
});
Expand Down