CLDR-14476 fa, remove explicit <LRM> or replace with \u200E; ko, remove a bogus < #1025
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Contributor
|
Isn't this actually ticket CLDR-14476? |
Contributor
|
Peter, this should be 14476 not 14477 |
Contributor
FrankYFTang
reviewed
Feb 11, 2021
Contributor
FrankYFTang
left a comment
There was a problem hiding this comment.
gee.. it is hard to review invisible characters but I made it.
Please change the commit subject to CLDR-14476
macchiati
reviewed
Feb 11, 2021
Member
macchiati
left a comment
There was a problem hiding this comment.
Only issue is the ticket number.
04ad398 to
726d195
Compare
|
Hooray! The files in the branch are the same across the force-push. 😃 ~ Your Friendly Jira-GitHub PR Checker Bot |
Contributor
Author
Thanks, I fixed the commit message, and also the ticket ID in this PR, please re-approve |
Member
I filed a ticket for that: https://unicode-org.atlassian.net/browse/CLDR-14496?filter=10033 |
macchiati
approved these changes
Feb 11, 2021
jefgen
added a commit
to microsoft/icu
that referenced
this pull request
Mar 5, 2021
…00E; ko, remove a bogus < This change cherry-picks fixes from the upstream CLDR repo to fix data issues in the fa and ko locales. The CLDR-MS was regenerated after picking up the fix. This change is the update to the MS-ICU data files from the updated data. Upstream PR: unicode-org/cldr#1025 Upstream tickets: https://unicode-org.atlassian.net/browse/CLDR-14476 https://unicode-org.atlassian.net/browse/ICU-21485
jefgen
added a commit
to microsoft/icu
that referenced
this pull request
Mar 5, 2021
…00E; ko, remove a bogus < This change cherry-picks fixes from the upstream CLDR repo to fix data issues in the fa and ko locales. The CLDR-MS was regenerated after picking up the fix. This change is the update to the MS-ICU data files from the updated data. Upstream PR: unicode-org/cldr#1025 Upstream tickets: https://unicode-org.atlassian.net/browse/CLDR-14476 https://unicode-org.atlassian.net/browse/ICU-21485
jefgen
added a commit
to microsoft/icu
that referenced
this pull request
Mar 5, 2021
…00E; ko, remove a bogus < (#71) This change cherry-picks fixes from the upstream CLDR repo to fix data issues in the fa and ko locales. The CLDR-MS was regenerated after picking up the fix. This change is the update to the MS-ICU data files from the updated data. Upstream PR: unicode-org/cldr#1025 Upstream tickets: https://unicode-org.atlassian.net/browse/CLDR-14476 https://unicode-org.atlassian.net/browse/ICU-21485
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
4 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Checklist
In fa, which has a bunch of ASCII <LRM> which were probably intended to be actual \u200E characters:
In ko, there was one bogus < in Japanese era name, removed it.
I will split off a separate ticket to add tests for a future Survey Tool phase.