feat: support data:image on mpris:artUrl #225
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
The resizing part isn't really necessary, OBS already has an option to keep an image source within certain bounds. |
|
Want me to create separate PR with only support for the data:image? |
|
Nah, just remove it, squash the commits and force push. |
|
did commit only for the support of the data:image in urls and then did refactor commit of the function so it all uses early returns |
|
If anyone ended up on this PR by accident when searching how to keep the images same size, way to resize the images in OBS is through filter called "Scaling/Aspect Ratio" when you right click on the image source. |
|
I actually meant this option in the transform for any source, it's also in the documentation on the obs forums: |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
adding support for data/image in urls, using existing config value config::cover_size so covers stop changing sizes between song source etc.., gotta adapt UI so it makes more sense but its functional