fix(svgo): handle javascript uris in removexss plugin #186
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
π Linked issue
N/A
β Type of change
π Description
The
removeXSSplugin for SVGO was missing one of the possible ways to execute scripts. SVGshrefattributes, regardless of namespace, can contain JavaScript URIs, which the client will execute.I recently updated the SVGO
removeScriptElementplugin to handle this. When v3.0.3 is released, you'll no longer need to maintain theremoveXSSplugin, and can instead opt for theremoveScriptElementplugin. This plugin is due to be renamed toremoveScripts.Documentation: https://svgo.dev/docs/plugins/remove-scripts/
I'm not sure when v3.0.3 can be released, so it's probably worth updating the plugin already. Once v3.0.3 is released, I'd be happy to open another PR to help with migrating over to it and dropping
removeXSS.Reference: svg/svgo#1664 (comment)
Chores
I also did the following chores:
onzoomevent, which is included in the list of events in SVGO.π Checklist