fix: uppercase windows drive letters #151
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Codecov ReportAll modified and coverable lines are covered by tests ✅
Additional details and impacted files@@ Coverage Diff @@
## main #151 +/- ##
=======================================
Coverage 99.41% 99.42%
=======================================
Files 4 4
Lines 342 346 +4
Branches 105 106 +1
=======================================
+ Hits 340 344 +4
Misses 2 2 ☔ View full report in Codecov by Sentry. |
pi0
reviewed
Jan 2, 2024
relative
pi0
approved these changes
Jan 10, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
🔗 Linked issue
resolves nuxt/nuxt#24621
❓ Type of change
📚 Description
It was possible for a path segment to mismatch (
c:!==C:) owing to drive letter case. This normalises it inrelativebefore splitting into segments.I can update this if #142 merges first.
📝 Checklist