chore: Add ControlExtensions.Icon support to TextBox #1288
Conversation
|
Azure Static Web Apps: Your stage site is ready! Visit it here: https://salmon-rock-0cfebe70f-1288.eastus2.azurestaticapps.net |
|
|
||
| private static void OnIconChanged(DependencyObject d, DependencyPropertyChangedEventArgs e) | ||
| { | ||
| if (d is TextBox textBox) |
There was a problem hiding this comment.
why constraint it to TextBox only? the target property accept any Control as recipient?
There was a problem hiding this comment.
But only TextBox supports LeadingIcon/Command/IsVisible, right?
In that case we should probably spit out a warning if someone is trying to set those properties on things other than a TextBox
There was a problem hiding this comment.
Should I use System.Diagnostics.Debug.WriteLine("...") for the warning?
There was a problem hiding this comment.
I used d.Log().LogWarning("...")
Uno.Themes/src/library/Uno.Material/Extensions/ControlExtensions.cs
Lines 247 to 253 in fcbeafc
|
Azure Static Web Apps: Your stage site is ready! Visit it here: https://salmon-rock-0cfebe70f-1288.eastus2.azurestaticapps.net |
GitHub Issue: #1286
PR Type
What kind of change does this PR introduce?
Description
PR Checklist
Please check if your PR fulfills the following requirements:
Other information
Internal Issue (If applicable):