fix(macOS): ignore option and command as standalone keys #22014
+40
−0
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Contributor
There was a problem hiding this comment.
Pull request overview
This PR fixes a bug on macOS where pressing the Command or Option keys alone would insert symbols into a TextBox. The fix adds these modifier keys to the list of keys that are ignored when pressed standalone, preventing them from triggering text input.
Key changes:
- Added VirtualKey.Menu (Option/Alt key) and related variants (LeftMenu, RightMenu) to the ignored keys list
- Added VirtualKey.LeftWindows and VirtualKey.RightWindows (Command keys on macOS) to the ignored keys list
- This ensures these modifier keys only have an effect when combined with other keys
5 tasks
Contributor
Contributor
|
🤖 Your Docs stage site is ready! Visit it here: https://unodocsprstaging.z13.web.core.windows.net/pr-22014/docs/index.html |
Contributor
|
🤖 Your WebAssembly Skia Sample App stage site is ready! Visit it here: https://unowasmprstaging.z20.web.core.windows.net/pr-22014/wasm-skia-net9/index.html |
Co-authored-by: spouliot <[email protected]>
Co-authored-by: spouliot <[email protected]>
test: Add coverage for Menu/Option and Windows/Command modifier keys
|
|
Contributor
|
🤖 Your Docs stage site is ready! Visit it here: https://unodocsprstaging.z13.web.core.windows.net/pr-22014/docs/index.html |
Contributor
|
🤖 Your WebAssembly Skia Sample App stage site is ready! Visit it here: https://unowasmprstaging.z20.web.core.windows.net/pr-22014/wasm-skia-net9/index.html |
Contributor
|
The build 186034 found UI Test snapshots differences: Details
|
Contributor
|
|
ajpinedam
approved these changes
Dec 6, 2025
MartinZikmund
approved these changes
Dec 8, 2025
Contributor
|
🤖 Your Docs stage site is ready! Visit it here: https://unodocsprstaging.z13.web.core.windows.net/pr-22014/docs/index.html |
Contributor
|
|
Contributor
|
/azp run |
|
Azure Pipelines successfully started running 2 pipeline(s). |
Contributor
|
🤖 Your Docs stage site is ready! Visit it here: https://unodocsprstaging.z13.web.core.windows.net/pr-22014/docs/index.html |
Contributor
|
The build 188069 found UI Test snapshots differences: Details
|
Contributor
|
|
Contributor
|
🤖 Your WebAssembly Skia Sample App stage site is ready! Visit it here: https://unowasmprstaging.z20.web.core.windows.net/pr-22014/wasm-skia-net9/index.html |
Contributor
|
🤖 Your Docs stage site is ready! Visit it here: https://unodocsprstaging.z13.web.core.windows.net/pr-22014/docs/index.html |
Contributor
|
The build 188766 found UI Test snapshots differences: Details
|
Contributor
|
The build 188766 found UI Test snapshots differences: Details
|
Contributor
|
|
Contributor
Author
|
I keep having That does not make sense since this specific test is annotated with Have you seen this on other PR @MartinZikmund ? |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
GitHub Issue: closes #21925
PR Type:
What is the current behavior? 🤔
Using Command or Option keys insert symbols to TextBox
What is the new behavior? 🚀
Unless it's a modifier (using with other keys) then the Command/Option key is ignored (when alone).
PR Checklist ✅
Please check if your PR fulfills the following requirements:
Screenshots Compare Test Runresults.Other information ℹ️