test: Add coverage for Menu/Option and Windows/Command modifier keys #22015
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
5 tasks
Co-authored-by: spouliot <[email protected]>
|
|
1 similar comment
|
|
Co-authored-by: spouliot <[email protected]>
Copilot
AI
changed the title
[WIP] WIP address changes based on feedback for macOS key handling fix
test: Add coverage for Menu/Option and Windows/Command modifier keys
Dec 2, 2025
spouliot
approved these changes
Dec 2, 2025
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
GitHub Issue: Related to #22014
PR Type:
🧪 Test
What is the current behavior? 🤔
The fix in #22014 added Menu/Option and Windows/Command keys to the ignored modifier keys list in
TextBox.skia.cs, but lacked test coverage for these newly ignored keys.What is the new behavior? 🚀
Added runtime test
When_Option_Or_Command_Key_Alone()that verifies pressing these modifier keys alone doesn't insert text into the TextBox:VirtualKey.Menu,LeftMenu,RightMenu(Option/Alt)VirtualKey.LeftWindows,RightWindows(Command on macOS)When_Shift()test patternPR Checklist ✅
Please check if your PR fulfills the following requirements:
Screenshots Compare Test Runresults.Other information ℹ️
This PR merges into #22014 to address review feedback requesting test coverage for the modifier key changes.
✨ Let Copilot coding agent set things up for you — coding agent works faster and does higher quality work when set up for your repo.