chore: add maui skia runtime package to sdk #20767
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Contributor
There was a problem hiding this comment.
Pull Request Overview
This PR adds support for the Maui Skia runtime package to the Uno SDK by updating the appropriate targets files and the package manifest.
- Added a new ItemGroup in iOS, MacCatalyst, and Android targets files conditioned on both “skiarenderer” and “mauiembedding” feature flags.
- Updated packages.json to include the new Uno.Extensions.Maui.WinUI.Runtime.Skia package.
Reviewed Changes
Copilot reviewed 4 out of 4 changed files in this pull request and generated no comments.
| File | Description |
|---|---|
| src/Uno.Sdk/targets/Uno.Implicit.Packages.ProjectSystem.iOS.targets | Added new ItemGroup with condition for Maui embedding and Skia renderer support. |
| src/Uno.Sdk/targets/Uno.Implicit.Packages.ProjectSystem.MacCatalyst.targets | Added new ItemGroup with condition for Maui embedding and Skia renderer support. |
| src/Uno.Sdk/targets/Uno.Implicit.Packages.ProjectSystem.Android.targets | Added new ItemGroup with condition for Maui embedding and Skia renderer support. |
| src/Uno.Sdk/packages.json | Updated package list with new runtime package dependency. |
Comments suppressed due to low confidence (3)
src/Uno.Sdk/targets/Uno.Implicit.Packages.ProjectSystem.iOS.targets:25
- [nitpick] Consider adding an inline comment explaining the rationale behind using both the 'skiarenderer' and 'mauiembedding' conditions to enhance clarity for future maintainers.
+ <ItemGroup Condition="$(UnoFeatures.Contains(';skiarenderer;')) AND $(UnoFeatures.Contains(';mauiembedding;'))">
src/Uno.Sdk/targets/Uno.Implicit.Packages.ProjectSystem.MacCatalyst.targets:25
- [nitpick] Consider adding a comment that explains why the new package reference is conditionally included with both 'skiarenderer' and 'mauiembedding' flags for clarity.
+ <ItemGroup Condition="$(UnoFeatures.Contains(';skiarenderer;')) AND $(UnoFeatures.Contains(';mauiembedding;'))">
src/Uno.Sdk/packages.json:301
- [nitpick] Consider updating comments or documentation (e.g., a changelog note) to detail the addition of this runtime package and its associated conditions.
+ "Uno.Extensions.Maui.WinUI.Runtime.Skia",
Contributor
|
🤖 Your Docs stage site is ready! Visit it here: https://unodocsprstaging.z13.web.core.windows.net/pr-20767/docs/index.html |
Contributor
|
🤖 Your WebAssembly Skia Sample App stage site is ready! Visit it here: https://unowasmprstaging.z20.web.core.windows.net/pr-20767/wasm-skia-net9/index.html |
jeromelaban
reviewed
Jun 11, 2025
src/Uno.Sdk/targets/Uno.Implicit.Packages.ProjectSystem.Android.targets
Outdated
Show resolved
Hide resolved
Contributor
|
🤖 Your Docs stage site is ready! Visit it here: https://unodocsprstaging.z13.web.core.windows.net/pr-20767/docs/index.html |
Contributor
|
🤖 Your WebAssembly Skia Sample App stage site is ready! Visit it here: https://unowasmprstaging.z20.web.core.windows.net/pr-20767/wasm-skia-net9/index.html |
Contributor
|
|
Contributor
|
The build 168253 found UI Test snapshots differences: Details
|
jeromelaban
reviewed
Jun 12, 2025
src/Uno.Sdk/targets/Uno.Implicit.Packages.ProjectSystem.Android.targets
Outdated
Show resolved
Hide resolved
Contributor
Author
|
https://github.com/Mergifyio backport release/stable/6.0 |
Contributor
✅ Backports have been createdDetails
|
Contributor
|
🤖 Your Docs stage site is ready! Visit it here: https://unodocsprstaging.z13.web.core.windows.net/pr-20767/docs/index.html |
Contributor
|
🤖 Your WebAssembly Skia Sample App stage site is ready! Visit it here: https://unowasmprstaging.z20.web.core.windows.net/pr-20767/wasm-skia-net9/index.html |
Contributor
|
The build 168328 found UI Test snapshots differences: Details
|
jeromelaban
approved these changes
Jun 13, 2025
ajpinedam
approved these changes
Jun 13, 2025
Contributor
|
🤖 Your WebAssembly Skia Sample App stage site is ready! Visit it here: https://unowasmprstaging.z20.web.core.windows.net/pr-20767/wasm-skia-net9/index.html |
Contributor
|
🤖 Your Docs stage site is ready! Visit it here: https://unodocsprstaging.z13.web.core.windows.net/pr-20767/docs/index.html |
Contributor
|
The build 168442 found UI Test snapshots differences: Details
|
agneszitte
added a commit
that referenced
this pull request
Jun 16, 2025
…6.0/pr-20767 chore: add maui skia runtime package to sdk (backport #20767)
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
related #20765