fix: remove privateassets="all" from mauiembedding bits #20797
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Contributor
Author
|
@Mergifyio backport release/stable/6.0 |
Contributor
✅ Backports have been createdDetails
|
Contributor
There was a problem hiding this comment.
Pull Request Overview
This PR removes the PrivateAssets="all" attribute from the implicit Skia runtime package reference in MAUI embedding target files, allowing the package to flow transitively to consuming projects.
- Dropped
PrivateAssets="all"onUno.Extensions.Maui.WinUI.Runtime.Skiareferences - Applied the change to iOS, MacCatalyst, and Android target files
Reviewed Changes
Copilot reviewed 3 out of 3 changed files in this pull request and generated no comments.
| File | Description |
|---|---|
| src/Uno.Sdk/targets/Uno.Implicit.Packages.ProjectSystem.iOS.targets | Removed PrivateAssets="all" from the Skia runtime reference |
| src/Uno.Sdk/targets/Uno.Implicit.Packages.ProjectSystem.MacCatalyst.targets | Removed PrivateAssets="all" from the Skia runtime reference |
| src/Uno.Sdk/targets/Uno.Implicit.Packages.ProjectSystem.Android.targets | Removed PrivateAssets="all" from the Skia runtime reference |
Comments suppressed due to low confidence (3)
src/Uno.Sdk/targets/Uno.Implicit.Packages.ProjectSystem.iOS.targets:26
- [nitpick] Consider updating the project documentation or release notes to mention that the Skia runtime package is now transitively exposed to downstream projects after removing
PrivateAssets="all".
<_UnoProjectSystemPackageReference Include="Uno.Extensions.Maui.WinUI.Runtime.Skia" ProjectSystem="true" />
src/Uno.Sdk/targets/Uno.Implicit.Packages.ProjectSystem.MacCatalyst.targets:26
- [nitpick] Consider updating the project documentation or release notes to mention that the Skia runtime package is now transitively exposed to downstream projects after removing
PrivateAssets="all".
<_UnoProjectSystemPackageReference Include="Uno.Extensions.Maui.WinUI.Runtime.Skia" ProjectSystem="true" />
src/Uno.Sdk/targets/Uno.Implicit.Packages.ProjectSystem.Android.targets:39
- [nitpick] Consider updating the project documentation or release notes to mention that the Skia runtime package is now transitively exposed to downstream projects after removing
PrivateAssets="all".
<_UnoProjectSystemPackageReference Include="Uno.Extensions.Maui.WinUI.Runtime.Skia" ProjectSystem="true" />
Contributor
|
🤖 Your Docs stage site is ready! Visit it here: https://unodocsprstaging.z13.web.core.windows.net/pr-20797/docs/index.html |
Contributor
|
🤖 Your WebAssembly Skia Sample App stage site is ready! Visit it here: https://unowasmprstaging.z20.web.core.windows.net/pr-20797/wasm-skia-net9/index.html |
agneszitte
approved these changes
Jun 16, 2025
Contributor
|
The build 168568 found UI Test snapshots differences: Details
|
agneszitte
added a commit
that referenced
this pull request
Jun 17, 2025
…6.0/pr-20797 fix: remove privateassets="all" from mauiembedding bits (backport #20797)
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Avoids error when using MAUI Embedding:
System.IO.FileNotFoundException: 'Could not load file or assembly 'Uno.Extensions.Maui.WinUI.Runtime.Skia, Version=255.255.255.255, Culture=neutral, PublicKeyToken=null' or one of its dependencies.'