fix(xamlreader): Accept valid toplevel properties and positional binding parameters #21784
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
nickrandolph
approved these changes
Nov 10, 2025
Contributor
There was a problem hiding this comment.
Pull Request Overview
This PR fixes issues with the FailOnUnknownProperties feature in the XamlReader by adding special handling for internal XAML members that should not be validated as properties. The changes prevent false positives when strict property validation is enabled for XAML parsing.
- Added handling to skip validation for the
basemember (used for XAML inheritance) - Added handling to skip validation for
_PositionalParameters(used internally for markup extension parameters like in{Binding Foo, Mode=TwoWay}) - Added comprehensive test coverage for various binding scenarios with
FailOnUnknownPropertiesenabled
Reviewed Changes
Copilot reviewed 2 out of 2 changed files in this pull request and generated 2 comments.
| File | Description |
|---|---|
| src/Uno.UI/UI/Xaml/Markup/Reader/XamlObjectBuilder.cs | Added two special-case checks to skip validation for internal XAML members base and _PositionalParameters when FailOnUnknownProperties is enabled |
| src/Uno.UI.RuntimeTests/Tests/Windows_UI_Xaml_Markup/Given_XamlReader.cs | Added comprehensive test coverage including valid/invalid binding scenarios, StaticResource usage, and a helper method EnsureFailOnUnknownProperty() for test setup |
Contributor
|
🤖 Your Docs stage site is ready! Visit it here: https://unodocsprstaging.z13.web.core.windows.net/pr-21784/docs/index.html |
Co-authored-by: Copilot <[email protected]>
Co-authored-by: Copilot <[email protected]>
kazo0
approved these changes
Nov 10, 2025
src/Uno.UI.RuntimeTests/Tests/Windows_UI_Xaml_Markup/Given_XamlReader.cs
Show resolved
Hide resolved
Contributor
|
🤖 Your Docs stage site is ready! Visit it here: https://unodocsprstaging.z13.web.core.windows.net/pr-21784/docs/index.html |
Contributor
|
🤖 Your WebAssembly Skia Sample App stage site is ready! Visit it here: https://unowasmprstaging.z20.web.core.windows.net/pr-21784/wasm-skia-net9/index.html |
Contributor
|
The build 182034 found UI Test snapshots differences: Details
|
Contributor
|
|
Contributor
|
@Mergifyio backport release/stable/6.4 |
Contributor
✅ Backports have been createdDetails
|
5 tasks
agneszitte
added a commit
that referenced
this pull request
Nov 14, 2025
…6.4/pr-21784 fix(xamlreader): Accept valid toplevel properties and positional binding parameters (backport #21784)
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
PR Type:
What is the current behavior? 🤔
Failures with:
The Property base does not exist on {http://schemas.microsoft.com/winfx/2006/xaml/presentation}Page...The type 'Microsoft.UI.Xaml.Data.Binding' does not contain a property or event named '_PositionalParameters'. [Line: 42 Position: 46];when bindings are placed inside a data templateWhat is the new behavior? 🚀
No failures.
PR Checklist ✅
Please check if your PR fulfills the following requirements:
Screenshots Compare Test Runresults.Other information ℹ️