-
Notifications
You must be signed in to change notification settings - Fork 834
fix(mcp): Adjust for no tools_update notification on claude/codex #21820
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. Weβll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Conversation
|
@Mergifyio backport release/stable/6.4 |
β Backports have been createdDetails
|
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Pull Request Overview
This PR fixes MCP (Model Context Protocol) integration issues for Claude Code and Codex CLI platforms that don't support the tools_update notification. It introduces a new --mcp-wait-tools-list flag to wait for upstream server tools before responding to tool list requests, and updates documentation across multiple platforms to use the correct dotnet dnx command syntax.
Key Changes
- Added
--mcp-wait-tools-listflag and logic to wait for upstream tools when Claude Code or Codex clients are detected - Updated CLI documentation (Claude, Codex, GitHub Copilot CLI) to use
dotnet dnxinstead ofdnx - Improved help text formatting alignment in Program.cs
Reviewed Changes
Copilot reviewed 6 out of 6 changed files in this pull request and generated 2 comments.
Show a summary per file
| File | Description |
|---|---|
| src/Uno.UI.DevServer.Cli/Program.cs | Added new --mcp-wait-tools-list option to help text and improved alignment |
| src/Uno.UI.DevServer.Cli/Mcp/McpProxy.cs | Added logic to detect Claude Code/Codex clients and wait for tools before responding to list_tools requests |
| src/Uno.UI.DevServer.Cli/CliManager.cs | Added parsing for --mcp-wait-tools-list flag and passes it to McpProxy |
| doc/articles/get-started-ai-gh-copilot-cli.md | Fixed command from dnx to dotnet dnx |
| doc/articles/get-started-ai-codex.md | Fixed command from dnx to dotnet dnx |
| doc/articles/get-started-ai-claude.md | Fixed command from dnx to dotnet dnx |
|
π€ Your Docs stage site is ready! Visit it here: https://unodocsprstaging.z13.web.core.windows.net/pr-21820/docs/index.html |
|
π€ Your WebAssembly Skia Sample App stage site is ready! Visit it here: https://unowasmprstaging.z20.web.core.windows.net/pr-21820/wasm-skia-net9/index.html |
|
The build 182556 found UI Test snapshots differences: Details
|
|
π€ Your Docs stage site is ready! Visit it here: https://unodocsprstaging.z13.web.core.windows.net/pr-21820/docs/index.html |
|
π€ Your WebAssembly Skia Sample App stage site is ready! Visit it here: https://unowasmprstaging.z20.web.core.windows.net/pr-21820/wasm-skia-net9/index.html |
|
|
|
The build 182582 found UI Test snapshots differences: Details
|
β¦6.4/pr-21820 fix(mcp): Adjust for no tools_update notification on claude/codex (backport #21820)
PR Type:
What is the new behavior? π
Fixes invalid tools listing and CLIs for more platforms in docs for claude and codex
PR Checklist β
Please check if your PR fulfills the following requirements:
Screenshots Compare Test Runresults.Other information βΉοΈ