feat: Enable partial code gen with invalid XAML #21834
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Contributor
There was a problem hiding this comment.
Pull Request Overview
This PR enables partial code generation to continue when invalid XAML is encountered, rather than stopping at the first error. The implementation captures parsing exceptions in a ParsingError property on XamlFileDefinition and allows the generation process to continue for other valid files.
Key Changes
- Modified XAML parsing to catch and store exceptions rather than throwing them
- Changed
XamlFileDefinitionto a record class with aParsingErrorproperty to track parsing failures - Updated code generation flow to process files individually, catching errors per-file instead of failing globally
- Improved immutability of XAML definition classes by converting fields to readonly properties
Reviewed Changes
Copilot reviewed 10 out of 12 changed files in this pull request and generated 3 comments.
Show a summary per file
| File | Description |
|---|---|
| XamlFileParser.cs | Refactored parsing to catch exceptions and store them in ParsingError; changed parsing methods to use ref parameters; improved error messages |
| XamlFileDefinition.cs | Converted to record class; added ParsingError property; made SourceLink required; removed manual Equals(object) override |
| XamlCodeGeneration.cs | Changed error handling to process exceptions via diagnostics instead of returning empty list; wrapped individual generation steps in try-catch; created XamlSource record type |
| XamlObjectDefinition.cs | Made class sealed; converted fields to readonly properties; added constructor overload; improved debugger display |
| XamlMemberDefinition.cs | Made class sealed; removed nullable owner parameter; converted fields to readonly properties |
| XamlGlobalStaticResourcesMap.cs | Changed to use primary constructor; made BuildResourceDictionaryMap static and private |
| IXamlLocation.cs | Made LinePosition property readonly |
| Given_Parser.cs | Updated test to expect generation continues with invalid XAML (no missing InitializeComponent) |
| RequiredAttribute.cs, Nullable.cs, IsExternalInit.cs | Added compatibility polyfills for C# language features |
| SourceGeneratorHelpers.projitems | Updated file paths for compatibility files; added RequiredAttribute |
src/SourceGenerators/Uno.UI.SourceGenerators/XamlGenerator/XamlCodeGeneration.cs
Outdated
Show resolved
Hide resolved
src/SourceGenerators/Uno.UI.SourceGenerators/XamlGenerator/XamlFileParser.cs
Outdated
Show resolved
Hide resolved
Contributor
|
🤖 Your Docs stage site is ready! Visit it here: https://unodocsprstaging.z13.web.core.windows.net/pr-21834/docs/index.html |
Contributor
|
🤖 Your Docs stage site is ready! Visit it here: https://unodocsprstaging.z13.web.core.windows.net/pr-21834/docs/index.html |
1 similar comment
Contributor
|
🤖 Your Docs stage site is ready! Visit it here: https://unodocsprstaging.z13.web.core.windows.net/pr-21834/docs/index.html |
5c243d2 to
235fc12
Compare
Contributor
|
🤖 Your Docs stage site is ready! Visit it here: https://unodocsprstaging.z13.web.core.windows.net/pr-21834/docs/index.html |
Contributor
|
🤖 Your WebAssembly Skia Sample App stage site is ready! Visit it here: https://unowasmprstaging.z20.web.core.windows.net/pr-21834/wasm-skia-net9/index.html |
Contributor
|
🤖 Your Docs stage site is ready! Visit it here: https://unodocsprstaging.z13.web.core.windows.net/pr-21834/docs/index.html |
Contributor
|
|
carldebilly
approved these changes
Nov 13, 2025
Contributor
|
🤖 Your Docs stage site is ready! Visit it here: https://unodocsprstaging.z13.web.core.windows.net/pr-21834/docs/index.html |
Contributor
|
🤖 Your WebAssembly Skia Sample App stage site is ready! Visit it here: https://unowasmprstaging.z20.web.core.windows.net/pr-21834/wasm-skia-net9/index.html |
Contributor
|
The build 182860 found UI Test snapshots differences: Details
|
Contributor
|
|
5 tasks
src/SourceGenerators/Uno.UI.SourceGenerators/XamlGenerator/XamlObjectDefinition.cs
Show resolved
Hide resolved
Contributor
|
🤖 Your WebAssembly Skia Sample App stage site is ready! Visit it here: https://unowasmprstaging.z20.web.core.windows.net/pr-21834/wasm-skia-net9/index.html |
Contributor
|
🤖 Your Docs stage site is ready! Visit it here: https://unodocsprstaging.z13.web.core.windows.net/pr-21834/docs/index.html |
Contributor
|
The build 182880 found UI Test snapshots differences: Details
|
Contributor
|
@Mergifyio backport release/stable/6.4 |
Contributor
✅ Backports have been createdDetails
|
5 tasks
dr1rrb
added a commit
that referenced
this pull request
Nov 14, 2025
…6.4/pr-21834 feat: Enable partial code gen with invalid XAML (backport #21834)
5 tasks
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
linked #21838
linked https://github.com/unoplatform/uno.hotdesign/issues/5418
✨ Feature
Enable partial code gen with invalid XAML
What is the current behavior? 🤔
Code gen stop as soon as an invalid XAML file is encountered
What is the new behavior? 🚀
Generation continue as long as possible while reporting
DiagnosticsPR Checklist ✅
Screenshots Compare Test Runresults.