Misc non functionnal adjustment for XAML code gen #21874
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
5 tasks
Contributor
There was a problem hiding this comment.
Pull Request Overview
This refactoring PR improves the XAML code generation test infrastructure by adjusting output directories and refactoring error handling. The main changes consolidate error reporting through a new context class and update the test infrastructure to organize output by test file name, preventing conflicts when tests share method names.
Key changes:
- Introduces
XamlFileParserContextfor centralized error collection during XAML parsing - Changes from single
ParsingErrortoParsingErrorscollection inXamlFileDefinition - Updates test output directory structure to include test file name, avoiding collisions
- Moves
SourceLinkinitialization earlier and includes it in cache key for correctness - Improves error reporting for invalid
RelativeSourcebindings
Reviewed Changes
Copilot reviewed 27 out of 263 changed files in this pull request and generated no comments.
Show a summary per file
| File | Description |
|---|---|
| XamlFileParserContext.cs | New context class for collecting parsing errors |
| XamlFileParser.cs | Refactored to use context-based error collection and fixed cache key |
| XamlFileParser.Cache.cs | Added Link property to cache key for correctness |
| XamlFileGenerator.cs | Uses XamlConstants and adds validation for RelativeSource |
| XamlFileDefinition.cs | Changed from single error to error collection |
| XamlCodeGeneration.cs | Updated to iterate over error collection |
| CSGenerator.cs | Modified output path to include test file name |
| Test output files | Generated test outputs in new directory structure |
Contributor
|
🤖 Your WebAssembly Skia Sample App stage site is ready! Visit it here: https://unowasmprstaging.z20.web.core.windows.net/pr-21874/wasm-skia-net9/index.html |
Contributor
|
🤖 Your Docs stage site is ready! Visit it here: https://unodocsprstaging.z13.web.core.windows.net/pr-21874/docs/index.html |
2936065 to
1691498
Compare
Contributor
There was a problem hiding this comment.
Pull Request Overview
Copilot reviewed 3 out of 239 changed files in this pull request and generated 1 comment.
Comments suppressed due to low confidence (2)
src/SourceGenerators/Uno.UI.SourceGenerators/XamlGenerator/XamlFileParser.cs:1
- [nitpick] The variable 'member' is declared as nullable but is not initialized. While it will be assigned in all code paths before use, initializing it to 'default' or 'null' makes the intent clearer and follows defensive programming practices.
src/SourceGenerators/Uno.UI.SourceGenerators/XamlGenerator/XamlFileParser.cs:1 - Corrected grammar from 'a positional members' to 'positional members'.
...rators/Uno.UI.SourceGenerators.Tests/XamlCodeGeneratorTests/Given_HotReloadEnabledInBuild.cs
Outdated
Show resolved
Hide resolved
Contributor
|
🤖 Your Docs stage site is ready! Visit it here: https://unodocsprstaging.z13.web.core.windows.net/pr-21874/docs/index.html |
Contributor
|
🤖 Your WebAssembly Skia Sample App stage site is ready! Visit it here: https://unowasmprstaging.z20.web.core.windows.net/pr-21874/wasm-skia-net9/index.html |
Contributor
|
The build 183647 found UI Test snapshots differences: Details
|
Contributor
|
|
jeromelaban
approved these changes
Nov 19, 2025
Contributor
|
🤖 Your Docs stage site is ready! Visit it here: https://unodocsprstaging.z13.web.core.windows.net/pr-21874/docs/index.html |
Contributor
|
🤖 Your WebAssembly Skia Sample App stage site is ready! Visit it here: https://unowasmprstaging.z20.web.core.windows.net/pr-21874/wasm-skia-net9/index.html |
Contributor
|
The build 183920 found UI Test snapshots differences: Details
|
c92934a to
b97e7fc
Compare
Contributor
|
🤖 Your WebAssembly Skia Sample App stage site is ready! Visit it here: https://unowasmprstaging.z20.web.core.windows.net/pr-21874/wasm-skia-net9/index.html |
Contributor
|
The build 184921 found UI Test snapshots differences: Details
|
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
🔄 Refactoring (no functional changes, no api changes)
What is the current behavior? 🤔
What is the new behavior? 🚀
PR Checklist ✅
Screenshots Compare Test Runresults.Other information ℹ️
This PR is based on #21867 that is expected to be merged first