feat: Add FromJson markup extension #21875
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Contributor
There was a problem hiding this comment.
Pull Request Overview
This PR adds a new JsonToObject markup extension to the Uno.UI.Toolkit, enabling developers to define structured sample data directly in XAML using JSON strings. The extension parses JSON payloads into dynamic object graphs (ExpandoObject and List<object?>) that can be bound to UI elements, eliminating the need for temporary view model classes during development and testing.
Key changes:
- New
JsonToObjectExtensionmarkup extension that converts JSON strings to dynamic objects - Internal
JsonToObjectParserutility for JSON-to-object conversion with flexible parsing options - XAML builder enhancement to support both
JsonToObjectandJsonToObjectExtensionsyntax - Comprehensive runtime tests validating JSON parsing, binding, and error scenarios
- Documentation with usage examples
Reviewed Changes
Copilot reviewed 5 out of 5 changed files in this pull request and generated 3 comments.
Show a summary per file
| File | Description |
|---|---|
src/Uno.UI/UI/Xaml/Markup/Reader/XamlObjectBuilder.cs |
Adds fallback logic to resolve properties on markup extension types with "Extension" suffix, enabling standard XAML markup extension naming conventions |
src/Uno.UI.Toolkit/Markup/JsonToObjectParser.cs |
Internal parser that converts JSON documents into dynamic object graphs using ExpandoObject for objects and List for arrays, with support for trailing commas and comments |
src/Uno.UI.Toolkit/Markup/JsonToObjectExtension.cs |
Markup extension implementation with ContentProperty attribute on Json property, providing JSON-to-object conversion with XamlParseException error handling |
src/Uno.UI.RuntimeTests/Tests/Uno_UI_Toolkit/Given_JsonToObject.cs |
Runtime tests covering basic JSON parsing, nested objects, arrays, ItemsControl binding, and error scenarios for invalid/empty JSON |
doc/articles/Uno.UI.Toolkit.md |
User documentation explaining the JsonToObject markup extension with a complete usage example showing JSON resource definition and binding |
Xiaoy312
approved these changes
Nov 18, 2025
Contributor
|
🤖 Your Docs stage site is ready! Visit it here: https://unodocsprstaging.z13.web.core.windows.net/pr-21875/docs/index.html |
Contributor
|
🤖 Your WebAssembly Skia Sample App stage site is ready! Visit it here: https://unowasmprstaging.z20.web.core.windows.net/pr-21875/wasm-skia-net9/index.html |
dr1rrb
approved these changes
Nov 18, 2025
Contributor
|
🤖 Your Docs stage site is ready! Visit it here: https://unodocsprstaging.z13.web.core.windows.net/pr-21875/docs/index.html |
Contributor
|
🤖 Your WebAssembly Skia Sample App stage site is ready! Visit it here: https://unowasmprstaging.z20.web.core.windows.net/pr-21875/wasm-skia-net9/index.html |
Contributor
|
🤖 Your Docs stage site is ready! Visit it here: https://unodocsprstaging.z13.web.core.windows.net/pr-21875/docs/index.html |
Contributor
|
🤖 Your WebAssembly Skia Sample App stage site is ready! Visit it here: https://unowasmprstaging.z20.web.core.windows.net/pr-21875/wasm-skia-net9/index.html |
Contributor
|
@mergify backport release/stable/6.4 |
Contributor
✅ Backports have been createdDetails
|
Contributor
|
🤖 Your WebAssembly Skia Sample App stage site is ready! Visit it here: https://unowasmprstaging.z20.web.core.windows.net/pr-21875/wasm-skia-net9/index.html |
Contributor
|
|
Contributor
|
🤖 Your WebAssembly Skia Sample App stage site is ready! Visit it here: https://unowasmprstaging.z20.web.core.windows.net/pr-21875/wasm-skia-net9/index.html |
Contributor
|
🤖 Your WebAssembly Skia Sample App stage site is ready! Visit it here: https://unowasmprstaging.z20.web.core.windows.net/pr-21875/wasm-skia-net9/index.html |
Contributor
|
🤖 Your WebAssembly Skia Sample App stage site is ready! Visit it here: https://unowasmprstaging.z20.web.core.windows.net/pr-21875/wasm-skia-net9/index.html |
899dbaf to
3315cb0
Compare
Contributor
|
🤖 Your WebAssembly Skia Sample App stage site is ready! Visit it here: https://unowasmprstaging.z20.web.core.windows.net/pr-21875/wasm-skia-net9/index.html |
3315cb0 to
400572f
Compare
Contributor
|
🤖 Your Docs stage site is ready! Visit it here: https://unodocsprstaging.z13.web.core.windows.net/pr-21875/docs/index.html |
Contributor
|
🤖 Your WebAssembly Skia Sample App stage site is ready! Visit it here: https://unowasmprstaging.z20.web.core.windows.net/pr-21875/wasm-skia-net9/index.html |
Contributor
|
The build 183819 found UI Test snapshots differences: Details
|
5 tasks
agneszitte
added a commit
that referenced
this pull request
Nov 19, 2025
…6.4/pr-21875 feat: Add FromJson markup extension (backport #21875)
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
PR Type:
What is the new behavior? 🚀
Adds a new JsonToObject in order load a DataContext object from a literal string in XAML resources.
PR Checklist ✅
Please check if your PR fulfills the following requirements:
Screenshots Compare Test Runresults.Other information ℹ️