fix: Fix cannot HR app with project dependency with code and rider #21921
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
jeromelaban
approved these changes
Nov 21, 2025
dr1rrb
commented
Nov 21, 2025
...UI.RemoteControl.Server.Processors/HotReload/MetadataUpdates/CompilationWorkspaceProvider.cs
Outdated
Show resolved
Hide resolved
Contributor
There was a problem hiding this comment.
Pull request overview
This PR fixes a hot reload issue where applications with project dependencies targeting different target frameworks (TFMs) could not be hot reloaded in VS Code and Rider. The fix follows the same pattern already established for RuntimeIdentifier handling.
Key Changes:
- Apply
TargetFrameworkonly to the head project during hot reload, not transitively to all referenced projects - Use temporary property
UnoHotReloadTargetFrameworkto avoid forcing TFM globally
Reviewed changes
Copilot reviewed 3 out of 3 changed files in this pull request and generated 2 comments.
| File | Description |
|---|---|
| src/Uno.UI.RemoteControl.Server.Processors/HotReload/ServerHotReloadProcessor.MetadataUpdate.cs | Removes TargetFramework from global properties and stores it as UnoHotReloadTargetFramework during hot reload workspace initialization |
| src/Uno.UI.RemoteControl/buildTransitive/Uno.WinUI.DevServer.props | Restores UnoHotReloadTargetFramework back to TargetFramework conditionally for projects that reference the Dev Server assembly |
src/Uno.UI.RemoteControl.Server.Processors/HotReload/ServerHotReloadProcessor.MetadataUpdate.cs
Outdated
Show resolved
Hide resolved
src/Uno.UI.RemoteControl.Server.Processors/HotReload/ServerHotReloadProcessor.MetadataUpdate.cs
Outdated
Show resolved
Hide resolved
Co-authored-by: Copilot <[email protected]>
Contributor
|
🤖 Your WebAssembly Skia Sample App stage site is ready! Visit it here: https://unowasmprstaging.z20.web.core.windows.net/pr-21921/wasm-skia-net9/index.html |
Contributor
|
🤖 Your Docs stage site is ready! Visit it here: https://unodocsprstaging.z13.web.core.windows.net/pr-21921/docs/index.html |
Contributor
|
The build 184511 found UI Test snapshots differences: Details
|
Contributor
|
@Mergifyio backport release/stable/6.4 |
Contributor
✅ Backports have been createdDetails
|
5 tasks
kazo0
added a commit
that referenced
this pull request
Nov 26, 2025
…6.4/pr-21921 fix: Fix cannot HR app with project dependency with code and rider (backport #21921)
kazo0
added a commit
that referenced
this pull request
Nov 26, 2025
…de and rider (backport #21921)"
kazo0
added a commit
that referenced
this pull request
Nov 26, 2025
…lease/stable/6.4/pr-21921 fix: Fix cannot HR app with project dependency with code and rider (backport #21921)"
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
closes #21893
closes #21549
closes #20820
🐞 Bugfix
Cannot HR app with proejct depedency with code and rider
What is the current behavior? 🤔
App's TFM if forcefully pushed to all projects, including referenced project that might not have the same one
What is the new behavior? 🚀
App's TFM is applied only on the head project
PR Checklist ✅
Screenshots Compare Test Runresults.