chore(deps): Avoid dependency on deprecated NuGet package #22137
Conversation
There was a problem hiding this comment.
Pull request overview
This PR attempts to update NuGet package dependencies from deprecated beta versions to stable versions and removes custom package sources. However, the changes introduce compilation issues by switching from framework-specific testing packages to base packages without adding the required MSTest verifier package.
Key Changes:
- Removes custom Azure DevOps package source references (
RestoreAdditionalProjectSources) - Updates
Microsoft.CodeAnalysis.CSharp.CodeFix.Testing.MSTestfrom beta version to base package - Updates
Microsoft.CodeAnalysis.CSharp.SourceGenerators.Testing.MSTestto base package variant - Removes comments explaining the need for the custom package source
Reviewed changes
Copilot reviewed 2 out of 2 changed files in this pull request and generated 3 comments.
| File | Description |
|---|---|
| src/Uno.Analyzers.Tests/Uno.Analyzers.Tests.csproj | Removes custom package source and updates CodeFix.Testing package from MSTest variant to base package |
| src/SourceGenerators/Uno.UI.SourceGenerators.Tests/Uno.UI.SourceGenerators.Tests.csproj | Removes custom package source and updates SourceGenerators.Testing package from MSTest variant to base package |
Critical Issues Found:
- Missing GitHub issue reference - PR description does not include required issue linking per repository guidelines
- Missing MSTest verifier packages - The switch from
.MSTestpackages to base packages removes the bundledMSTestVerifiertype, but no explicitMicrosoft.CodeAnalysis.Testing.Verifiers.MSTestpackage reference was added to either project, which will cause compilation failures
src/SourceGenerators/Uno.UI.SourceGenerators.Tests/Uno.UI.SourceGenerators.Tests.csproj
Show resolved
Hide resolved
|
🤖 Your WebAssembly Skia Sample App stage site is ready! Visit it here: https://unowasmprstaging.z20.web.core.windows.net/pr-22137/wasm-skia-net9/index.html |
|
🤖 Your Docs stage site is ready! Visit it here: https://unodocsprstaging.z13.web.core.windows.net/pr-22137/docs/index.html |
|
🤖 Your WebAssembly Skia Sample App stage site is ready! Visit it here: https://unowasmprstaging.z20.web.core.windows.net/pr-22137/wasm-skia-net9/index.html |
|
🤖 Your Docs stage site is ready! Visit it here: https://unodocsprstaging.z13.web.core.windows.net/pr-22137/docs/index.html |
|
🤖 Your WebAssembly Skia Sample App stage site is ready! Visit it here: https://unowasmprstaging.z20.web.core.windows.net/pr-22137/wasm-skia-net9/index.html |
|
🤖 Your Docs stage site is ready! Visit it here: https://unodocsprstaging.z13.web.core.windows.net/pr-22137/docs/index.html |
|
|
|
@MartinZikmund @ajpinedam This is green now. Can you merge it please? Thanks! |
|
Ping @MartinZikmund @ajpinedam |
GitHub Issue: closes #
PR Type:
What is the current behavior? 🤔
What is the new behavior? 🚀
PR Checklist ✅
Please check if your PR fulfills the following requirements:
Screenshots Compare Test Runresults.Other information ℹ️