chore: use Uno.icu-win instead of Microsoft.ICU.ICU4C.Runtime #22169
Conversation
There was a problem hiding this comment.
Pull request overview
This PR migrates from Microsoft's ICU runtime package to Uno Platform's own ICU package for Windows Skia platforms. This change updates ICU from version 72 to version 77 for Windows-based Skia runtime projects (WPF and Win32), addressing performance concerns referenced in the linked issue. The migration aligns with Uno Platform's existing pattern of using platform-specific ICU packages (like Uno.icu-macos, Uno.icu-wasm, Uno.icu-ios) rather than relying on third-party packages.
Key changes:
- Updates ICU library version from 72 to 77 for Windows platforms
- Replaces Microsoft.ICU.ICU4C.Runtime with Uno.icu-win package
- Updates centralized version management in Directory.Build.targets
Reviewed changes
Copilot reviewed 4 out of 4 changed files in this pull request and generated 1 comment.
| File | Description |
|---|---|
| src/Uno.UI/UI/Xaml/Documents/UnicodeText.ICU.skia.cs | Updates Windows ICU version constant from 72 to 77 and changes native library name from icuuc72 to icuuc77, with updated comment |
| src/Uno.UI.Runtime.Skia.Wpf/Uno.UI.Runtime.Skia.Wpf.csproj | Replaces Microsoft.ICU.ICU4C.Runtime package reference with Uno.icu-win |
| src/Uno.UI.Runtime.Skia.Win32/Uno.UI.Runtime.Skia.Win32.csproj | Replaces Microsoft.ICU.ICU4C.Runtime package reference with Uno.icu-win |
| src/Directory.Build.targets | Bumps UnoICUVersion from 77.1.0-dev.46 to 77.1.0-dev.66 and adds PackageReference Update entry for Uno.icu-win |
|
🤖 Your WebAssembly Skia Sample App stage site is ready! Visit it here: https://unowasmprstaging.z20.web.core.windows.net/pr-22169/wasm-skia-net9/index.html |
|
🤖 Your Docs stage site is ready! Visit it here: https://unodocsprstaging.z13.web.core.windows.net/pr-22169/docs/index.html |
|
|
GitHub Issue: closes unoplatform/performance#20
PR Type:
What is the current behavior? 🤔
What is the new behavior? 🚀
PR Checklist ✅
Please check if your PR fulfills the following requirements:
Screenshots Compare Test Runresults.Other information ℹ️