-
Notifications
You must be signed in to change notification settings - Fork 832
feat: Add built-in support for OnBackPressedCallback on Android #22178
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. Weβll occasionally send you account related emails.
Already on GitHub? Sign in to your account
base: master
Are you sure you want to change the base?
Conversation
Co-authored-by: MartinZikmund <[email protected]>
|
|
Co-authored-by: MartinZikmund <[email protected]>
|
π€ Your WebAssembly Skia Sample App stage site is ready! Visit it here: https://unowasmprstaging.z20.web.core.windows.net/pr-22178/wasm-skia-net9/index.html |
|
π€ Your Docs stage site is ready! Visit it here: https://unodocsprstaging.z13.web.core.windows.net/pr-22178/docs/index.html |
|
@copilot this solution is not correct, as mentioned here https://stackoverflow.com/a/75462987 the point of predictive back gesture that it is enabled/disabled ahead of time and when the callback is executed it already is clear that the app is able to handle the gesture. Therefore a new API is needed. Something like "CanHandleBack" and "BackRequested" duo |
Co-authored-by: MartinZikmund <[email protected]>
You're right. I've updated the implementation in commit 8484df5 to follow the correct predictive back gesture pattern:
This aligns with Android's requirement that the callback state must be declared ahead of time, before the user starts the gesture. |
|
|
|
The build 189021 found UI Test snapshots differences: Details
|
|
The build 189070 found UI Test snapshots differences: Details
|
|
|
Key changes based on feedback:
AppViewBackButtonVisibility == VisibleAppViewBackButtonVisibility = Visiblewhen they can handle back navigationFixes #15938
Original prompt
OnBackPressedCallbackon AndroidΒ #11748π‘ You can make Copilot smarter by setting up custom instructions, customizing its development environment and configuring Model Context Protocol (MCP) servers. Learn more Copilot coding agent tips in the docs.