-
Notifications
You must be signed in to change notification settings - Fork 10
ci: consolidate build Environment, split fast vs heavy checks, and reusable workflows #299
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
yonch
commented
Sep 18, 2025
yonch
commented
Sep 18, 2025
- Unified Containerfile with cargo-chef and targets
- Containerfile:1
- Targets: builder (devtools), collector, nri-init
- Includes rustfmt, clippy, cargo-chef, clang/libelf, and Helm for fast-tier checks.
- Fast-tier workflow (fmt, clippy, unit tests, helm lint/template)
- .github/workflows/ci-fast.yaml:1
- Builds the builder image once and runs cargo/Helm inside it via docker run.
- Reusable workflows (workflow_call) per integration area
- Collector (GH-hosted assumptions + optional heavy S3): .github/workflows/reusable/test-collector.yaml:1
- Resctrl (GH-hosted unit + optional e2e smoke on metal): .github/workflows/reusable/test-resctrl.yaml:1
- Helm e2e (k3s + helm install, S3 smoke): .github/workflows/reusable/test-helm.yaml:1
- NRI integration (GH-hosted k3s): .github/workflows/reusable/test-nri.yaml:1
- Orchestrator workflow to wire everything and gate heavy tests by “level”
- .github/workflows/ci-orchestrator.yaml:1
- Builds collector and nri-init once (reusing Containerfile targets); then runs:
- Fast checks (uses ci-fast)
- NRI GH-hosted integration
- Conditionally runs heavy suites (collector/resctrl/helm) based on level:
- PRs: level cheap-short (heavy disabled)
- Push to main: level full-long
- Manual dispatch: selectable level
- Updated existing build workflows to the new Containerfile
- .github/workflows/build-component-artifacts.yaml:1
- Uses Containerfile with target: collector|nri-init
- .github/workflows/build-collector.yaml:1
- Triggers on Containerfile instead of Dockerfile.* and keeps multi-arch manifest
complete migration and retire old flows
bf0d535 to
6f54df3
Compare
… we run it in its own job anyway
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.