Thanks to visit codestin.com
Credit goes to github.com

Skip to content

Conversation

@MANASAB805
Copy link
Collaborator

Description

This PR adds a cargo publish --dry-run step to the GitHub Actions workflow to catch potential issues before the actual publishing process begins.

Changes

  • Added a dry-run step before the actual publish step
  • The dry-run will fail if there are any issues with the package that would prevent publishing
  • This helps catch potential issues early in the CI process

Testing

The changes have been tested by running cargo clippy --features debug to ensure they meet the project's coding standards.

Related Issues

Closes #456

@jonasstrehle jonasstrehle changed the base branch from main to release/0.0.7 October 29, 2025 07:21
@jonasstrehle jonasstrehle added this to the Release 0.0.7 milestone Oct 29, 2025
@jonasstrehle
Copy link
Member

jonasstrehle commented Oct 29, 2025

Thanks for your PR @MANASAB805,
Three things to consider:

  1. We should actually avoid --allow-dirty flag to make sure our lock file matches the dependencies, otherwise the build might fail or is not binary identical between the releases and the repository
  2. We need to run the dry run prior to the publish job, as just running the dry run directly before the publish doesn't help us avoid conflicts, as the release branch has been already merged then (so we have to run the dry run in the test workflow and only if we are on a release branch (starting with patter release/**). We can skip the dry run for all other feature branches, as this is expected to fail as of local development settings
  3. Please rebase the branch to release/0.0.7 in order to allow us adding this to the new release cycle

Could you make those adaptions? If done we would be good to merge your contribution.

FYI see https://github.com/unyt-org/datex-core/blob/feat/fmt/CONTRIBUTING.md

@jonasstrehle jonasstrehle marked this pull request as draft October 29, 2025 07:46
@MANASAB805 MANASAB805 force-pushed the feature/add-cargo-publish-dry-run branch from 7e1b0c1 to dfae9bc Compare October 30, 2025 10:08
@MANASAB805 MANASAB805 marked this pull request as ready for review October 30, 2025 10:09
@MANASAB805
Copy link
Collaborator Author

@jonasstrehle I've made the requested changes:

  • Moved the dry-run to the test workflow
  • Removed the --allow-dirty flag
  • Configured it to only run on release branches
  • Rebased onto release/0.0.7

The PR is now ready for review. Let me know if you'd like any adjustments!

@jonasstrehle jonasstrehle requested a review from benStre November 1, 2025 07:40
@jonasstrehle jonasstrehle mentioned this pull request Nov 1, 2025
@jonasstrehle jonasstrehle force-pushed the feature/add-cargo-publish-dry-run branch from dfae9bc to ba61485 Compare November 3, 2025 10:01
@jonasstrehle jonasstrehle requested review from jonasstrehle and removed request for benStre November 3, 2025 10:01
@jonasstrehle jonasstrehle merged commit bf225ab into unyt-org:release/0.0.7 Nov 3, 2025
2 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

Projects

None yet

Development

Successfully merging this pull request may close these issues.

Add cargo dry run in commit action

2 participants