Thanks to visit codestin.com
Credit goes to github.com

Skip to content

deprecate core value trait #520

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Open
janiejestemja wants to merge 1 commit into
base: release/0.0.7
Choose a base branch
from
Open

deprecate core value trait #520

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
5 changes: 0 additions & 5 deletions src/values/core_value_trait.rs
View file
Open in desktop

This file was deleted.

3 changes: 0 additions & 3 deletions src/values/core_values/boolean.rs
View file
Open in desktop
Original file line number Diff line number Diff line change
@@ -1,4 +1,3 @@
use super::super::core_value_trait::CoreValueTrait;
use crate::stdlib::string::String;
use crate::stdlib::string::ToString;
use crate::traits::structural_eq::StructuralEq;
Expand Down Expand Up @@ -40,8 +39,6 @@ impl Display for Boolean {
}
}

impl CoreValueTrait for Boolean {}

impl StructuralEq for Boolean {
fn structural_eq(&self, other: &Self) -> bool {
self.0 == other.0
Expand Down
3 changes: 0 additions & 3 deletions src/values/core_values/decimal/typed_decimal.rs
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -4,7 +4,6 @@ use crate::stdlib::ops::{Add, AddAssign, Sub};
use crate::stdlib::string::String;
use crate::traits::structural_eq::StructuralEq;
use crate::traits::value_eq::ValueEq;
use crate::values::core_value_trait::CoreValueTrait;
use crate::values::core_values::decimal::Decimal;
use crate::values::core_values::error::NumberParseError;
use core::fmt::Display;
Expand Down Expand Up @@ -112,8 +111,6 @@ impl Hash for TypedDecimal {
}
}

impl CoreValueTrait for TypedDecimal {}

impl StructuralEq for TypedDecimal {
fn structural_eq(&self, other: &Self) -> bool {
match (self, other) {
Expand Down
3 changes: 0 additions & 3 deletions src/values/core_values/endpoint.rs
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -6,7 +6,6 @@ use crate::stdlib::vec::Vec;
use crate::traits::structural_eq::StructuralEq;
use crate::utils::buffers::buffer_to_hex;
use crate::values::core_value::CoreValue;
use crate::values::core_value_trait::CoreValueTrait;
use crate::values::value_container::{ValueContainer, ValueError};
use binrw::io::Cursor;
use binrw::{BinRead, BinWrite};
Expand Down Expand Up @@ -99,8 +98,6 @@ impl<T: Into<ValueContainer>> TryFrom<Option<T>> for Endpoint {
// }
// }

impl CoreValueTrait for Endpoint {}

impl StructuralEq for Endpoint {
fn structural_eq(&self, other: &Self) -> bool {
self == other
Expand Down
2 changes: 0 additions & 2 deletions src/values/core_values/integer/typed_integer.rs
View file
Open in desktop
Original file line number Diff line number Diff line change
@@ -1,5 +1,4 @@
use crate::values::{
core_value_trait::CoreValueTrait,
core_values::{
error::NumberParseError,
integer::{
Expand Down Expand Up @@ -469,7 +468,6 @@ impl Display for TypedInteger {
}
}

impl CoreValueTrait for TypedInteger {}
// FIXME #343 discuss on structural vs partial equality for integers
impl StructuralEq for TypedInteger {
fn structural_eq(&self, other: &Self) -> bool {
Expand Down
3 changes: 0 additions & 3 deletions src/values/core_values/list.rs
View file
Open in desktop
Original file line number Diff line number Diff line change
@@ -1,4 +1,3 @@
use super::super::core_value_trait::CoreValueTrait;
use crate::stdlib::ops::Index;
use crate::stdlib::vec::Vec;
use crate::traits::structural_eq::StructuralEq;
Expand Down Expand Up @@ -80,8 +79,6 @@ impl List {
}
}

impl CoreValueTrait for List {}

impl StructuralEq for List {
fn structural_eq(&self, other: &Self) -> bool {
if self.len() != other.len() {
Expand Down
3 changes: 0 additions & 3 deletions src/values/core_values/map.rs
View file
Open in desktop
Original file line number Diff line number Diff line change
@@ -1,4 +1,3 @@
use super::super::core_value_trait::CoreValueTrait;
use crate::collections::HashMap;
use crate::std_random::RandomState;
use crate::stdlib::format;
Expand Down Expand Up @@ -486,8 +485,6 @@ impl Hash for Map {
}
}

impl CoreValueTrait for Map {}

impl Display for Map {
fn fmt(&self, f: &mut fmt::Formatter) -> fmt::Result {
core::write!(f, "{{")?;
Expand Down
3 changes: 0 additions & 3 deletions src/values/core_values/text.rs
View file
Open in desktop
Original file line number Diff line number Diff line change
@@ -1,4 +1,3 @@
use super::super::core_value_trait::CoreValueTrait;
use crate::stdlib::ops::{Add, AddAssign};
use crate::stdlib::string::String;
use crate::stdlib::string::ToString;
Expand Down Expand Up @@ -144,8 +143,6 @@ impl Text {
}
}

impl CoreValueTrait for Text {}

impl StructuralEq for Text {
fn structural_eq(&self, other: &Self) -> bool {
self.0 == other.0
Expand Down
3 changes: 0 additions & 3 deletions src/values/core_values/type.rs
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -14,7 +14,6 @@ use crate::types::definition::TypeDefinition;
use crate::types::structural_type_definition::StructuralTypeDefinition;
use crate::types::type_container::TypeContainer;
use crate::values::core_value::CoreValue;
use crate::values::core_value_trait::CoreValueTrait;
use crate::values::core_values::boolean::Boolean;
use crate::values::core_values::text::Text;
use crate::values::value_container::ValueContainer;
Expand Down Expand Up @@ -291,8 +290,6 @@ impl Type {
}
}

impl CoreValueTrait for Type {}

impl StructuralEq for Type {
fn structural_eq(&self, other: &Self) -> bool {
self.type_definition.structural_eq(&other.type_definition)
Expand Down
1 change: 0 additions & 1 deletion src/values/mod.rs
View file
Open in desktop
Original file line number Diff line number Diff line change
@@ -1,5 +1,4 @@
pub mod core_value;
pub mod core_value_trait;
pub mod core_values;
pub mod pointer;
pub mod value;
Expand Down
Loading