Core type: Range #521

janiejestemja · 2025-12-17T09:13:34Z

Adressing New core type: Range #508

github-actions · 2025-12-17T09:21:02Z

Test Results

577 tests +4 577 ✅ +4 1m 11s ⏱️ -1s
6 suites ±0 0 💤 ±0
1 files ±0 0 ❌ ±0

Results for commit 3d61a16. ± Comparison against base commit c3a822a.

♻️ This comment has been updated with latest results.

github-actions · 2025-12-17T10:05:36Z

Bencher Report

Branch	feat/ranges
Testbed	ubuntu-latest

Click to view all benchmark results

Benchmark	Latency	Benchmark Result microseconds (µs) (Result Δ%)	Upper Boundary microseconds (µs) (Limit %)
dxb to json/test1.json	📈 view plot 🚷 view threshold	61.09 µs (-4.04%) Baseline: 63.66 µs	67.75 µs (90.18%)
dxb to json/test2.json	📈 view plot 🚷 view threshold	13,138.00 µs (-1.02%) Baseline: 13,273.71 µs	13,731.99 µs (95.67%)
dxb to json/test3.json	📈 view plot 🚷 view threshold	139,250.00 µs (-2.16%) Baseline: 142,318.57 µs	148,660.48 µs (93.67%)
dxb to runtime value/test1.json	📈 view plot 🚷 view threshold	54.49 µs (+37.37%) Baseline: 39.67 µs	58.87 µs (92.57%)
dxb to runtime value/test2.json	📈 view plot 🚷 view threshold	14,500.00 µs (+32.88%) Baseline: 10,912.00 µs	15,694.70 µs (92.39%)
dxb to runtime value/test3.json	📈 view plot 🚷 view threshold	163,120.00 µs (+68.25%) Baseline: 96,953.29 µs	182,005.23 µs (89.62%)
json to dxb/test1.json	📈 view plot 🚷 view threshold	7,637.20 µs (+365.47%) Baseline: 1,640.76 µs	9,334.33 µs (81.82%)
json to dxb/test2.json	📈 view plot 🚷 view threshold	8,074,300.00 µs (+513.97%) Baseline: 1,315,094.29 µs	9,987,089.41 µs (80.85%)
json to dxb/test3.json	📈 view plot 🚷 view threshold	46,471,000.00 µs (+461.25%) Baseline: 8,279,928.57 µs	57,278,673.87 µs (81.13%)
json to runtime value datex auto static detection/test1.json	📈 view plot 🚷 view threshold	7,635.70 µs (+363.29%) Baseline: 1,648.15 µs	9,330.14 µs (81.84%)
json to runtime value datex auto static detection/test2.json	📈 view plot 🚷 view threshold	8,131,400.00 µs (+512.15%) Baseline: 1,328,338.57 µs	10,056,602.04 µs (80.86%)
json to runtime value datex auto static detection/test3.json	📈 view plot 🚷 view threshold	46,716,000.00 µs (+457.65%) Baseline: 8,377,271.43 µs	57,565,485.36 µs (81.15%)
json to runtime value datex forced static/test1.json	📈 view plot 🚷 view threshold	7,764.20 µs (+367.59%) Baseline: 1,660.46 µs	9,491.51 µs (81.80%)
json to runtime value datex forced static/test2.json	📈 view plot 🚷 view threshold	8,270,200.00 µs (+514.80%) Baseline: 1,345,190.00 µs	10,229,911.37 µs (80.84%)
json to runtime value datex forced static/test3.json	📈 view plot 🚷 view threshold	47,249,000.00 µs (+461.78%) Baseline: 8,410,657.14 µs	58,239,852.70 µs (81.13%)
json to runtime value datex/test1.json	📈 view plot 🚷 view threshold	7,600.40 µs (+361.32%) Baseline: 1,647.52 µs	9,285.01 µs (81.86%)
json to runtime value datex/test2.json	📈 view plot 🚷 view threshold	8,106,300.00 µs (+510.45%) Baseline: 1,327,927.14 µs	10,024,517.30 µs (80.86%)
json to runtime value datex/test3.json	📈 view plot 🚷 view threshold	46,765,000.00 µs (+456.48%) Baseline: 8,403,685.71 µs	57,620,860.79 µs (81.16%)
json to runtime value json_syntax/test1.json	📈 view plot 🚷 view threshold	21.23 µs (+4.74%) Baseline: 20.27 µs	21.81 µs (97.37%)
json to runtime value json_syntax/test2.json	📈 view plot 🚷 view threshold	6,579.00 µs (+0.28%) Baseline: 6,560.54 µs	6,983.02 µs (94.21%)
json to runtime value json_syntax/test3.json	📈 view plot 🚷 view threshold	71,034.00 µs (-13.73%) Baseline: 82,343.14 µs	97,027.52 µs (73.21%)
json to runtime value serde_json/test1.json	📈 view plot 🚷 view threshold	6.22 µs (-0.99%) Baseline: 6.28 µs	6.53 µs (95.23%)
json to runtime value serde_json/test2.json	📈 view plot 🚷 view threshold	2,049.50 µs (-3.62%) Baseline: 2,126.50 µs	2,232.92 µs (91.79%)
json to runtime value serde_json/test3.json	📈 view plot 🚷 view threshold	14,999.00 µs (-7.70%) Baseline: 16,249.86 µs	18,491.05 µs (81.11%)
runtime init	📈 view plot 🚷 view threshold	32.63 µs (-76.44%) Baseline: 138.50 µs	1,198.67 µs (2.72%)
runtime value to dxb/test1.json	📈 view plot 🚷 view threshold	5.92 µs (+61.16%) Baseline: 3.67 µs	6.55 µs (90.29%)
runtime value to dxb/test2.json	📈 view plot 🚷 view threshold	1,732.40 µs (+75.25%) Baseline: 988.54 µs	1,942.97 µs (89.16%)
runtime value to dxb/test3.json	📈 view plot 🚷 view threshold	20,277.00 µs (+95.99%) Baseline: 10,346.07 µs	23,122.31 µs (87.69%)
runtime value to json datex/test1.json	📈 view plot 🚷 view threshold	68.07 µs (-0.28%) Baseline: 68.27 µs	71.20 µs (95.60%)
runtime value to json datex/test2.json	📈 view plot 🚷 view threshold	14,770.00 µs (+2.82%) Baseline: 14,365.14 µs	15,083.07 µs (97.92%)
runtime value to json datex/test3.json	📈 view plot 🚷 view threshold	161,140.00 µs (+4.02%) Baseline: 154,918.57 µs	164,468.85 µs (97.98%)
runtime value to json json_syntax/test1.json	📈 view plot 🚷 view threshold	10.63 µs (-0.90%) Baseline: 10.73 µs	11.04 µs (96.26%)
runtime value to json json_syntax/test2.json	📈 view plot 🚷 view threshold	4,400.90 µs (-2.93%) Baseline: 4,533.86 µs	4,760.35 µs (92.45%)
runtime value to json json_syntax/test3.json	📈 view plot 🚷 view threshold	62,508.00 µs (-1.68%) Baseline: 63,573.71 µs	70,252.49 µs (88.98%)
runtime value to json serde_json/test1.json	📈 view plot 🚷 view threshold	3.70 µs (+21.27%) Baseline: 3.05 µs	3.96 µs (93.33%)
runtime value to json serde_json/test2.json	📈 view plot 🚷 view threshold	1,384.70 µs (+32.33%) Baseline: 1,046.36 µs	1,510.84 µs (91.65%)
runtime value to json serde_json/test3.json	📈 view plot 🚷 view threshold	16,077.00 µs (+47.09%) Baseline: 10,929.99 µs	17,858.20 µs (90.03%)

🐰 View full continuous benchmarking report in Bencher

…instead

janiejestemja

Currently missing

#523

janiejestemja · 2025-12-19T12:44:48Z

src/visitor/expression/mod.rs

        Ok(VisitAction::SkipChildren)
    }
+
+    fn visit_range_definition(


Add visitor for Range #527

janiejestemja · 2025-12-19T12:45:25Z

src/libs/core.rs

    Unit,                                // #core.Unit
    Never,                               // #core.never
    Unknown,                             // #core.unknown
+    RangeDefinition,


Add new Core Type Range to core lib #525

janiejestemja · 2025-12-19T12:46:45Z

src/ast/structs/expression.rs

    /// Integer, e.g 123456789123456789
    Integer(Integer),

+    RangeDefinition(RangeDefinition),


Implement AST for Range #522

janiejestemja · 2025-12-19T12:48:28Z

src/decompiler/ast_to_source_code.rs

            }
            DatexExpressionData::Noop => "".to_string(),
            DatexExpressionData::Integer(i) => i.to_string(),
+            DatexExpressionData::RangeDefinition(range) => range.to_string(),


Add decompiler support for Range #526

janiejestemja · 2025-12-19T12:52:54Z

src/core_compiler/value_compiler.rs

            append_instruction_code(buffer, InstructionCode::SCOPE_END);
        }
+        CoreValue::RangeDefinition(range) => {
+            append_instruction_code(buffer, InstructionCode::RANGE);


Compiler addition: Range #524

janiejestemja · 2025-12-19T12:55:40Z

src/values/core_values/range.rs

+    pub end: Integer,
+}
+
+impl From<RangeDefinition> for Range<Integer> {


Add from impls from rust ranges #528

jonasstrehle · 2025-12-19T13:31:42Z

I'd suggest to rename the core value to "Range"

janiejestemja linked an issue Dec 17, 2025 that may be closed by this pull request

New core type: Range #508

Open

janiejestemja changed the title ~~New core type: Range~~ Core type: Range Dec 17, 2025

janiejestemja added 16 commits December 18, 2025 21:07

add range to core values

9831dfd

add display trait

15c593a

refactor display and debug

63d6549

outfactor steps from range definition

a29e889

add some error handling for fallible ranges

15a3efa

outfactor formatting into separate unit tests

2855797

add invalid range to unit test cases

e0c27be

removed test cases for decimals from ranges

b47ecc5

remove typed integers and fallible iterator implementations

823ca58

add from frange and partial eq to range definition

ff5bbe8

move getter and setter from defintion to iterator

69768a8

add step by function to range

53daa73

edit formatting test case

624b736

removed generics and iterator

41c41b5

remove manual impl of partial eq from ranges and add hash derivation …

d9ddc9e

…instead

WIP ranges marked todo!('OutRanged')

9ccf691

janiejestemja force-pushed the feat/ranges branch from f63dc8e to 9ccf691 Compare December 18, 2025 20:08

janiejestemja added 3 commits December 19, 2025 00:00

WIP ranges marked panic!('OutRanged')

f3c0591

WIP ranges lost markers...

2088b9a

WIP ranges add test for range to ast

89cacbb

janiejestemja commented Dec 19, 2025

View reviewed changes

renamed RangeDefinition to Range

3d61a16

Provide feedback

Saved searches

Use saved searches to filter your results more quickly

Uh oh!

Uh oh!

Core type: Range #521

Core type: Range #521

janiejestemja commented Dec 17, 2025

Uh oh!

github-actions bot commented Dec 17, 2025 •

edited

Loading

Uh oh!

github-actions bot commented Dec 17, 2025 •

edited

Loading

Uh oh!

janiejestemja left a comment •

edited

Loading

Uh oh!

janiejestemja Dec 19, 2025

Uh oh!

janiejestemja Dec 19, 2025

Uh oh!

janiejestemja Dec 19, 2025

Uh oh!

janiejestemja Dec 19, 2025

Uh oh!

janiejestemja Dec 19, 2025

Uh oh!

janiejestemja Dec 19, 2025

Uh oh!

jonasstrehle commented Dec 19, 2025

Uh oh!

Reviewers

Assignees

Labels

Projects

Milestone

Development

Uh oh!

3 participants

Uh oh!

Core type: Range #521

Are you sure you want to change the base?

Core type: Range #521

Conversation

janiejestemja commented Dec 17, 2025

Uh oh!

github-actions bot commented Dec 17, 2025 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Test Results

Uh oh!

github-actions bot commented Dec 17, 2025 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Bencher Report

Uh oh!

janiejestemja left a comment • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Choose a reason for hiding this comment

Uh oh!

janiejestemja Dec 19, 2025

Choose a reason for hiding this comment

Uh oh!

janiejestemja Dec 19, 2025

Choose a reason for hiding this comment

Uh oh!

janiejestemja Dec 19, 2025

Choose a reason for hiding this comment

Uh oh!

janiejestemja Dec 19, 2025

Choose a reason for hiding this comment

Uh oh!

janiejestemja Dec 19, 2025

Choose a reason for hiding this comment

Uh oh!

janiejestemja Dec 19, 2025

Choose a reason for hiding this comment

Uh oh!

jonasstrehle commented Dec 19, 2025

Uh oh!

Reviewers

Assignees

Labels

Projects

Milestone

Development

Uh oh!

3 participants

github-actions bot commented Dec 17, 2025 •

edited

Loading

github-actions bot commented Dec 17, 2025 •

edited

Loading

janiejestemja left a comment •

edited

Loading