refactor: database model to avoid postgres jsonb queries #161
Conversation
* Move database schema to a subpackage named "modele"
There was a problem hiding this comment.
Pull Request Overview
This PR refactors the database model to avoid querying jsonb columns by storing specific pipeline report information directly in PostgreSQL table columns, thereby improving performance. Key changes include removing old model definitions in favor of new ones in the pkg/model package, updating query functions and handlers to work with the new schema, and revising SQL queries to accommodate these structural changes.
Reviewed Changes
Copilot reviewed 10 out of 13 changed files in this pull request and generated 1 comment.
Show a summary per file
| File | Description |
|---|---|
| pkg/server/scmDBSpec.go | Removed old DatabaseSCMRow definitions in favor of the new model.SCM struct. |
| pkg/server/scmDBQuery.go | Updated dbGetScm to return model.SCM and adjusted usage accordingly. |
| pkg/server/scmDBHandler.go | Updated function signatures and queries to use model.SCM instead of the old type. |
| pkg/server/reportHandler.go | Revised report creation and query functions to work with the new schema. |
| pkg/server/reportDBSpec.go | Removed outdated PipelineReportRow definitions. |
| pkg/server/reportDBQuery.go | Refactored report insertion and search queries to use model.PipelineReport and new query logic. |
| pkg/model/scm.go | Introduced new SCM model with appropriate fields. |
| pkg/model/pipelinereport.go | Introduced new PipelineReport model with necessary pipeline fields. |
| .golangci.yml | Updated linting configuration; added rules for package restrictions. |
Files not reviewed (3)
- go.mod: Language not supported
- pkg/database/migrations/000004_alter_pipelineReports.down.sql: Language not supported
- pkg/database/migrations/000004_alter_pipelineReports.up.sql: Language not supported
| switch len(ids) { | ||
| // If no scm is found, we insert it | ||
| case 0: | ||
| id, err := dbInsertSCM(target.Scm.URL, target.Scm.Branch.Source) |
There was a problem hiding this comment.
The branch value used in dbInsertSCM is taken from target.Scm.Branch.Source even though the condition checks target.Scm.Branch.Target; consider using the same branch field consistently.
| id, err := dbInsertSCM(target.Scm.URL, target.Scm.Branch.Source) | |
| id, err := dbInsertSCM(target.Scm.URL, target.Scm.Branch.Target) |
Refactor the database to store specific pipeline reports information such as
name,result, ortarget scm idsdirectly in postgresql table column instead of querying them from jsonb column.The goal is to improve performance.
Description
Test
Right now tested manually, including upgrade from Udash 0.7.0
Additional Information
Tradeoff
Potential improvement