Thanks to visit codestin.com
Credit goes to github.com

Skip to content

Allow mget to accept both array and spreaded array #657

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
ogzhanolguncu merged 6 commits into from
Oct 19, 2023
Merged

Allow mget to accept both array and spreaded array #657

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
6 commits
Select commit Hold shift + click to select a range
5e59ebc
Allow mget to accept both array and spreaded array
ogzhanolguncu Oct 17, 2023
cb226d4
Add tests for mget to redis.test
ogzhanolguncu Oct 17, 2023
32ca69f
Move allowing array or spreaded values into mget command
ogzhanolguncu Oct 18, 2023
5080841
Revert mget change in redis file
ogzhanolguncu Oct 18, 2023
f1821cc
Merge branch 'main' into DX-399
ogzhanolguncu Oct 18, 2023
82032a3
refactor: clean up command
chronark Oct 19, 2023
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
13 changes: 7 additions & 6 deletions pkg/commands/mget.ts
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -2,14 +2,15 @@ import { Command, CommandOptions } from "./command.ts";
/**
* @see https://redis.io/commands/mget
*/
export class MGetCommand<TData extends unknown[]> extends Command<
(string | null)[],
TData
> {
export class MGetCommand<TData extends unknown[]>
extends Command<(string | null)[], TData> {
constructor(
cmd: [...keys: string[]],
cmd: [string[]] | [...string[] | string[]],
opts?: CommandOptions<(string | null)[], TData>,
) {
super(["mget", ...cmd], opts);
const keys = Array.isArray(cmd[0])
? (cmd[0] as string[])
: (cmd as string[]);
super(["mget", ...keys], opts);
}
}
23 changes: 23 additions & 0 deletions pkg/redis.test.ts
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -37,6 +37,29 @@ Deno.test("when storing base64 data", async (t) => {
});
});

Deno.test("mget", async (t) => {
const key = newKey();
const key1 = newKey();
const value = "foobar";
const value1 = "foobar1";
const redis = new Redis(client);
const queries = [key, key1];

await t.step("mget with array", async () => {
await redis.mset({ key: value, key1: value1 });
const res = await redis.mget(queries);

assertEquals(res.length, 2);
});

await t.step("mget with spreaded array", async () => {
await redis.mset({ key: value, key1: value1 });
const res = await redis.mget(...queries);

assertEquals(res.length, 2);
});
});

Deno.test("when destructuring the redis class", async (t) => {
await t.step("correctly binds this", async () => {
const { get, set } = new Redis(client);
Expand Down
10 changes: 5 additions & 5 deletions pkg/redis.ts
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -416,7 +416,9 @@ export class Redis {
new BitOpCommand(
[op as any, destinationKey, sourceKey, ...sourceKeys],
this.opts,
).exec(this.client);
).exec(
this.client,
);

/**
* @see https://redis.io/commands/bitpos
Expand Down Expand Up @@ -604,10 +606,8 @@ export class Redis {
count?: number,
withValues?: boolean,
) =>
new HRandFieldCommand<TData>(
[key, count, withValues] as any,
this.opts,
).exec(this.client);
new HRandFieldCommand<TData>([key, count, withValues] as any, this.opts)
.exec(this.client);

/**
* @see https://redis.io/commands/hscan
Expand Down