fix(hgetall): handle unsafe integer in deserialization #664
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Contributor
Author
|
All tests is passing in my local machine. |
Contributor
Yeah, I'm checking. |
|
🎉 This PR is included in version 1.24.0-next.2 🎉 The release is available on: Your semantic-release bot 📦🚀 |
Contributor
Author
|
@ogzhanolguncu Just a suggestion, I think the env isn't available for outsider contributors is a problem to fix. It's easier to review PRs if the CI works for any contributor. |
Contributor
|
Yeah, we are working on it soon it will be available for all. And, don't let that stop you, please keep contributing. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Close #662
Close #497