Thanks to visit codestin.com
Credit goes to github.com

Skip to content

Fix missing assertions and paths #701

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
ogzhanolguncu merged 1 commit into from
Oct 30, 2023
Merged

Fix missing assertions and paths #701

ogzhanolguncu merged 1 commit into from
Oct 30, 2023

Conversation

@ogzhanolguncu
Copy link
Contributor

@ogzhanolguncu ogzhanolguncu commented Oct 30, 2023 •
edited
Loading

Some of the import paths and assertions are missing.And, some assertions are hiding under those falsy assertions. We had to add necessary toBe's and toEquals's


expect(res.length, 2);
expect(typeof res[0], "number");
expect(res![1].length > 0, true);

@linear
Copy link

linear bot commented Oct 30, 2023

DX-429 Fix missing assertions from upstash-redis

We missed some of the assertions when migrating from deno to bun. we need to fix this.

@ogzhanolguncu ogzhanolguncu merged commit acc0588 into main Oct 30, 2023
@ogzhanolguncu ogzhanolguncu deleted the DX-429 branch October 30, 2023 08:27
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

No reviews

Assignees

No one assigned

Labels

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

2 participants

@ogzhanolguncu