fix: add file extensions #716
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Contributor
|
Nice catch. Yeah I tested it with CF pages, workers pretty much everywhere and works. Thank you. Close #698 |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This ought to fix #698.
I think, error is related to the way TypeScript and Node.js handle module resolution and imports, particularly in relation to the ECMAScript modules.
When set to bundler, TypeScript is told that the code will be bundled by another tool, so it loosens the rules with imports, allowing imports without file extensions or with
.tsextensions. This is especially useful for projects that will be bundled using tools like Webpack, Rollup, or others, as it aligns with the way these tools resolve modules.However, it's important to note that while TypeScript allows for omitting extensions with the bundler option, Node.js and in-browser JavaScript still expect file extensions to be present for ESM. This is because, in the world of ESM, file extensions cannot be omitted.