Thanks to visit codestin.com
Credit goes to github.com

Skip to content

Fix GEOSEARCH Command when Limit is set #782

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
ogzhanolguncu merged 2 commits into from
Dec 14, 2023
Merged

Fix GEOSEARCH Command when Limit is set #782

ogzhanolguncu merged 2 commits into from
Dec 14, 2023

Conversation

@mxzinke
Copy link
Contributor

@mxzinke mxzinke commented Dec 14, 2023

The COUNT (both on GEOSEARCH and GEOSEARCHSTORE) was missing according the official Redis Docs: https://redis.io/commands/geosearch/

I need this change to improve performance on my application with working COUNT Limit.

Before the fix, I got the following error:

[UpstashError]: ERR syntax error, command was: ["GEOSEARCH","cache:hotels:geo-index","FROMLONLAT",-8.672491,37.10109,"BYRADIUS",10,"KM","ASC",50]

@ogzhanolguncu
Copy link
Contributor

ogzhanolguncu commented Dec 14, 2023 •
edited
Loading

@mxzinke Can you update the tests with COUNT for both of the files?

@ogzhanolguncu ogzhanolguncu merged commit d9c08ac into upstash:main Dec 14, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

No reviews

Assignees

No one assigned

Labels

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

2 participants

@mxzinke @ogzhanolguncu