feat: add bitfield command #1159
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
resolves #1150
Contributor
Author
|
I tried to model the code after the python implementation.
|
Contributor
ogzhanolguncu
left a comment
There was a problem hiding this comment.
Overall it looks great. There are just some minor convention issues.
(also addresses pr comments)
Contributor
Author
|
One thing that can be addressed is being able to infer the length of the result |
opt to pass private properties / methods from pipeline directly into the constructor for the bitfield command. no need to create two separate classes for command and pipeline
ogzhanolguncu
approved these changes
Jul 3, 2024
Contributor
ogzhanolguncu
left a comment
There was a problem hiding this comment.
Looking awesome. Thanks.
CahidArda
approved these changes
Jul 3, 2024
renovate bot
referenced
this pull request
in inabagumi/shinju-date
Jul 4, 2024
[](https://renovatebot.com) This PR contains the following updates: | Package | Change | Age | Adoption | Passing | Confidence | |---|---|---|---|---|---| | [@upstash/redis](https://togithub.com/upstash/upstash-redis) | [`^1.31.6` -> `^1.32.0`](https://renovatebot.com/diffs/npm/@upstash%2fredis/1.31.6/1.32.0) | [](https://docs.renovatebot.com/merge-confidence/) | [](https://docs.renovatebot.com/merge-confidence/) | [](https://docs.renovatebot.com/merge-confidence/) | [](https://docs.renovatebot.com/merge-confidence/) | --- ### Release Notes <details> <summary>upstash/upstash-redis (@​upstash/redis)</summary> ### [`v1.32.0`](https://togithub.com/upstash/redis-js/releases/tag/v1.32.0) [Compare Source](https://togithub.com/upstash/upstash-redis/compare/v1.31.6...v1.32.0) #### What's Changed - DX-1023: Add regex for base url by [@​CahidArda](https://togithub.com/CahidArda) in [https://github.com/upstash/redis-js/pull/1157](https://togithub.com/upstash/redis-js/pull/1157) - feat: add bitfield command by [@​lewxdev](https://togithub.com/lewxdev) in [https://github.com/upstash/redis-js/pull/1159](https://togithub.com/upstash/redis-js/pull/1159) - Resolve Auto Pipeline Arrappend Issue by [@​CahidArda](https://togithub.com/CahidArda) in [https://github.com/upstash/redis-js/pull/1165](https://togithub.com/upstash/redis-js/pull/1165) #### New Contributors - [@​lewxdev](https://togithub.com/lewxdev) made their first contribution in [https://github.com/upstash/redis-js/pull/1159](https://togithub.com/upstash/redis-js/pull/1159) **Full Changelog**: upstash/redis-js@v1.31.6...v1.32.0 </details> --- ### Configuration 📅 **Schedule**: Branch creation - At any time (no schedule defined), Automerge - At any time (no schedule defined). 🚦 **Automerge**: Enabled. ♻ **Rebasing**: Whenever PR becomes conflicted, or you tick the rebase/retry checkbox. 🔕 **Ignore**: Close this PR and you won't be reminded about this update again. --- - [ ] <!-- rebase-check -->If you want to rebase/retry this PR, check this box --- This PR has been generated by [Mend Renovate](https://www.mend.io/free-developer-tools/renovate/). View repository job log [here](https://developer.mend.io/github/inabagumi/shinju-date). <!--renovate-debug:eyJjcmVhdGVkSW5WZXIiOiIzNy40MjEuOSIsInVwZGF0ZWRJblZlciI6IjM3LjQyMS45IiwidGFyZ2V0QnJhbmNoIjoibWFpbiIsImxhYmVscyI6WyJkZXBlbmRlbmNpZXMiXX0=--> Co-authored-by: renovate[bot] <29139614+renovate[bot]@users.noreply.github.com>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
resolves #1150