Thanks to visit codestin.com
Credit goes to github.com

Skip to content

Resolve Auto Pipeline Arrappend Issue #1165

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
ogzhanolguncu merged 1 commit into from
Jul 4, 2024
Merged

Resolve Auto Pipeline Arrappend Issue #1165

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
6 changes: 4 additions & 2 deletions pkg/auto-pipeline.test.ts
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -13,6 +13,7 @@ describe("Auto pipeline", () => {
test("should execute all commands inside a Promise.all in a single pipeline", async () => {
const persistentKey = newKey();
const persistentKey2 = newKey();
const persistentKey3 = newKey();
const scriptHash = await new ScriptLoadCommand(["return 1"]).exec(client);

const redis = Redis.fromEnv({
Expand Down Expand Up @@ -143,10 +144,11 @@ describe("Auto pipeline", () => {
redis.zscore(newKey(), "member"),
redis.zunionstore(newKey(), 1, [newKey()]),
redis.zunion(1, [newKey()]),
redis.json.set(newKey(), "$", { hello: "world" }),
redis.json.set(persistentKey3, '$', { log: ["one", "two"] }),
redis.json.arrappend(persistentKey3, "$.log", '"three"'),
]);
expect(result).toBeTruthy();
expect(result.length).toBe(120); // returns
expect(result.length).toBe(121); // returns
// @ts-expect-error pipelineCounter is not in type but accessible120 results
expect(redis.pipelineCounter).toBe(1);
});
Expand Down
5 changes: 4 additions & 1 deletion pkg/auto-pipeline.ts
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -34,7 +34,10 @@ export function createAutoPipelineProxy(_redis: Redis, json?: boolean): Redis {
}

// If the method is a function on the pipeline, wrap it with the executor logic
if (typeof redis.autoPipelineExecutor.pipeline[command as keyof Pipeline] === "function") {
const isFunction = json
? typeof redis.autoPipelineExecutor.pipeline.json[command as keyof Pipeline["json"]] === "function"
: typeof redis.autoPipelineExecutor.pipeline[command as keyof Pipeline] === "function"
if (isFunction) {
return (...args: CommandArgs<typeof Command>) => {
// pass the function as a callback
return redis.autoPipelineExecutor.withAutoPipeline((pipeline) => {
Expand Down