In auto pipeline, throw errors seperately #1305
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
17356d6 to
45a8d03
Compare
ytkimirti
approved these changes
Oct 9, 2024
Collaborator
ytkimirti
left a comment
There was a problem hiding this comment.
@CahidArda lets not forget to add info about keepErrors option to the release notes
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Addressing the auto pipeline issue which causes upstash/ratelimit-js#122
Essentially, when one of the commands in the pipeline fail, all threw an error in the autopipeline, which is not ideal. Fixing the issue by throwing the errors individually, in the auto pipeline code.