Thanks to visit codestin.com
Credit goes to github.com

Skip to content

fix: add polyfill for atob #282

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
chronark merged 3 commits into from
Dec 19, 2022
Merged

fix: add polyfill for atob #282

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
3 commits
Select commit Hold shift + click to select a range
c23a5aa
fix: add polyfill for atob
chronark Dec 19, 2022
29da3d1
style: fmt
chronark Dec 19, 2022
bd649de
fix: type error
chronark Dec 19, 2022
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
1 change: 1 addition & 0 deletions .gitignore
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -18,3 +18,4 @@ examples/**/pnpm-lock.yaml

# Local Netlify folder
.netlify
x/
4 changes: 4 additions & 0 deletions deno.lock
View file
Open in desktop

Some generated files are not rendered by default. Learn more about how customized files appear on GitHub.

2 changes: 1 addition & 1 deletion pkg/commands/zrange.ts
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -67,7 +67,7 @@ export class ZRangeCommand<TData extends unknown[]> extends Command<
if (
typeof opts?.count !== "undefined" && typeof opts?.offset !== "undefined"
) {
command.push("limit", opts.offset, opts.count);
command.push("limit", opts!.offset, opts!.count);
}
if (opts?.withScores) {
command.push("withscores");
Expand Down
9 changes: 9 additions & 0 deletions platforms/node_with_fetch.ts
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -18,6 +18,15 @@ import "isomorphic-fetch";
// import http from "http";
// import "isomorphic-fetch";

/**
* Workaround for nodejs 14, where atob is not included in the standardlib
*/
if (typeof atob === "undefined") {
global.atob = function (b64: string) {
return Buffer.from(b64, "base64").toString("utf-8");
};
}

export type { Requester, UpstashRequest, UpstashResponse };

/**
Expand Down
9 changes: 9 additions & 0 deletions platforms/nodejs.ts
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -11,6 +11,15 @@ import {
} from "../pkg/http.ts";
import { VERSION } from "../version.ts";

/**
* Workaround for nodejs 14, where atob is not included in the standardlib
*/
if (typeof atob === "undefined") {
global.atob = function (b64: string) {
return Buffer.from(b64, "base64").toString("utf-8");
};
}

export type { Requester, UpstashRequest, UpstashResponse };

/**
Expand Down