Thanks to visit codestin.com
Credit goes to github.com

Skip to content

fix: smembers generic type #283

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
chronark merged 2 commits into from
Dec 19, 2022
Merged

fix: smembers generic type #283

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
2 commits
Select commit Hold shift + click to select a range
01e7a62
fix: smembers generic type
chronark Dec 19, 2022
51c3d85
test: fix types
chronark Dec 19, 2022
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
2 changes: 1 addition & 1 deletion pkg/commands/smembers.test.ts
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -14,7 +14,7 @@ Deno.test("returns all members of the set", async () => {
const value2 = { v: randomID() };

await new SAddCommand([key, value1, value2]).exec(client);
const res = await new SMembersCommand<{ v: string }>([key]).exec(client);
const res = await new SMembersCommand<{ v: string }[]>([key]).exec(client);

assertEquals(res!.length, 2);
assertEquals(res!.map(({ v }) => v).includes(value1.v), true);
Expand Down
11 changes: 6 additions & 5 deletions pkg/commands/smembers.ts
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -3,11 +3,12 @@ import { Command, CommandOptions } from "./command.ts";
/**
* @see https://redis.io/commands/smembers
*/
export class SMembersCommand<TData = string> extends Command<
unknown[],
TData[]
> {
constructor(cmd: [key: string], opts?: CommandOptions<unknown[], TData[]>) {
export class SMembersCommand<TData extends unknown[] = string[]>
extends Command<
unknown[],
TData
> {
constructor(cmd: [key: string], opts?: CommandOptions<unknown[], TData>) {
super(["smembers", ...cmd], opts);
}
}
5 changes: 3 additions & 2 deletions pkg/pipeline.ts
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -778,8 +778,9 @@ export class Pipeline {
/**
* @see https://redis.io/commands/smembers
*/
smembers = (...args: CommandArgs<typeof SMembersCommand>) =>
this.chain(new SMembersCommand(args, this.commandOptions));
smembers = <TData extends unknown[] = string[]>(
...args: CommandArgs<typeof SMembersCommand>
) => this.chain(new SMembersCommand<TData>(args, this.commandOptions));

/**
* @see https://redis.io/commands/smove
Expand Down
5 changes: 3 additions & 2 deletions pkg/redis.ts
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -750,8 +750,9 @@ export class Redis {
/**
* @see https://redis.io/commands/smembers
*/
smembers = (...args: CommandArgs<typeof SMembersCommand>) =>
new SMembersCommand(args, this.opts).exec(this.client);
smembers = <TData extends unknown[] = string[]>(
...args: CommandArgs<typeof SMembersCommand>
) => new SMembersCommand<TData>(args, this.opts).exec(this.client);

/**
* @see https://redis.io/commands/smove
Expand Down