Thanks to visit codestin.com
Credit goes to github.com

Skip to content

set options #350

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
chronark merged 9 commits into from
May 13, 2023
Merged

set options #350

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
9 commits
Select commit Hold shift + click to select a range
ab22048
test: add argument to unlink
chronark Mar 30, 2023
215ed13
Merge branch 'main' of https://github.com/upstash/upstash-redis
chronark Mar 31, 2023
67a06e9
Merge branch 'main' of https://github.com/upstash/upstash-redis
chronark Apr 14, 2023
4d5c119
Merge branch 'main' of https://github.com/upstash/upstash-redis
chronark Apr 18, 2023
273b8b7
Merge branch 'main' of https://github.com/upstash/upstash-redis
chronark May 4, 2023
5ca136c
Merge branch 'main' of https://github.com/upstash/upstash-redis
chronark May 4, 2023
4c311b5
refactor(set): change SetCommandOptions type to intersection type
chronark May 13, 2023
5515f7c
fix(set.ts): make get option optional in SetCommandOptions type defin…
chronark May 13, 2023
8953bbb
test(set.test.ts): change nx flag to xx flag in get with xx test
chronark May 13, 2023
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
12 changes: 12 additions & 0 deletions pkg/commands/set.test.ts
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -99,6 +99,18 @@ Deno.test("get", async (t) => {
assertEquals(res, old);
});
});

Deno.test("get with xx", async (t) => {
await t.step("gets the old value", async () => {
const key = newKey();
const old = randomID();
const value = randomID();
await new SetCommand([key, old]).exec(client);

const res = await new SetCommand([key, value, { get: true, xx: true }]).exec(client);
assertEquals(res, old);
});
});
Deno.test("nx", async (t) => {
await t.step("when key exists", async (t) => {
await t.step("does nothing", async () => {
Expand Down
14 changes: 7 additions & 7 deletions pkg/commands/set.ts
View file
Open in desktop
Original file line number Diff line number Diff line change
@@ -1,20 +1,20 @@
import { Command, CommandOptions } from "./command.ts";

export type SetCommandOptions =
| { get: boolean }
| (
& { get?: boolean }
& (
| { ex: number; px?: never; exat?: never; pxat?: never; keepTtl?: never }
| { ex?: never; px: number; exat?: never; pxat?: never; keepTtl?: never }
| { ex?: never; px?: never; exat: number; pxat?: never; keepTtl?: never }
| { ex?: never; px?: never; exat?: never; pxat: number; keepTtl?: never }
| { ex?: never; px?: never; exat?: never; pxat?: never; keepTtl: true }
| { ex?: never; px?: never; exat?: never; pxat?: never; keepTtl?: never }
)
& (
| { nx: true; xx?: never }
| { xx: true; nx?: never }
| { xx?: never; nx?: never }
);
& (
| { nx: true; xx?: never }
| { xx: true; nx?: never }
| { xx?: never; nx?: never }
);

/**
* @see https://redis.io/commands/set
Expand Down
2 changes: 1 addition & 1 deletion version.ts
View file
Open in desktop
Original file line number Diff line number Diff line change
@@ -1 +1 @@
export const VERSION = "development";
export const VERSION = "development"