Infer chained response types in Pipeline #352
Closed
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
What?
Adds support for inferred pipeline types like this:
How?
commandsarray is stored on thePipelineclass itself.chainis then updated to return aPipelinetype with whatever command was just chained fed into the class-level generic.execis updated to return the type of thecommandsarray mapped to each item's response type. Kept the empty case asunknown[]for backward compatibility.Gotchas
TS thinks that each
.chaincall returns a newPipelineinstance, which means that the type inference only works if the chain is kept intact frompipeline()toexec(). Splitting the pipeline up for use in loops etc will still require manually overridingexec<['like', 'this']>