Issue 90 - Query builder interface #105
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
db.go
Outdated
Member
Author
There was a problem hiding this comment.
How come you have Join, LeftJoin, FullJoin, etc... on the Result interface? why not keep the Result the same and have just the Builder() have those methods? for example, similar to how upper.io/db v2 already works with squirrel in the Pressly API. Keeps builder separated from basic result set operations.
Member
Author
There was a problem hiding this comment.
I think the QueryBuilder, instead of returning a Result, should return a Query type
This was referenced Sep 28, 2015
xiam
added a commit
that referenced
this pull request
Dec 13, 2015
Issue 90 - Query builder interface
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Issue #90