This repository was archived by the owner on Aug 14, 2019. It is now read-only.
pin to local time because using local desk #1074
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
joemfb
reviewed
Feb 17, 2019
sys/vane/clay.hoon
Outdated
| [%foreign-x (scot %p our) (scot %p her) syd car (scot cas) pax] | ||
| %f %build live=%.n %pin | ||
| :: XX perhaps should be now as in ++validate-plops | ||
| (case-to-date cas) |
Contributor
There was a problem hiding this comment.
It does seem like this should also be now. (This comment also needs a trailing empty line.)
Contributor
|
I think this should be tested further before merging. I'll try some local fake-ship experiments. Should be easier to replicate now that the problem is clear (ie, wait a little while before booting a fake ~marzod). |
joemfb
approved these changes
Mar 7, 2019
Contributor
joemfb
left a comment
There was a problem hiding this comment.
LGTM. And sorry for the delay
Merged
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This worked once upon a time in another branch, and it's pretty clearly correct, but I haven't tested it directly against current hotfix.