This repository was archived by the owner on Aug 14, 2019. It is now read-only.
More accurately represent Ethereum RPC filter topics #1079
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Rather than a flat list of topics to watch for, it is an indexed list of topics to watch for in those specific positions. As such, items in that list may also be zero (null, matches any topic), or a list of topics (matches any one of those topics). Additionally, topics are always specified using 32 bytes, so there is no need to specify length explicitly.
Contributor
Author
|
I updated the hoon structures for incoming Ethereum state to also match. @philipcmonk and I discussed the solution for this out of band. Please confirm this is in line with that and looks sane. |
philipcmonk
approved these changes
Feb 22, 2019
Contributor
philipcmonk
left a comment
There was a problem hiding this comment.
Yep, i.topics.log is better
Merged
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Relevant Ethereum JSON RPC docs section.
Rather than a flat list of topics to watch for, it is an indexed/ordered list of topics to watch for in those specific positions. As such, items in that list may either be:
Additionally, topics are always specified using 32 bytes, so there is no need to specify length explicitly.