This repository was archived by the owner on Aug 14, 2019. It is now read-only.
Add a readme #1121
Merged
Add a readme #1121
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Contributor
|
V nice. Yeah, I think we have to have the .md file for GitHub purposes. Too
bad %clay barfs when it sees this. I'm not sure what the answer is here
besides making a bogus .md mark that just renders as text?
—
~poldec-tonteg
http://urbit.org
…On Mon, Mar 25, 2019 at 9:28 AM Fang ***@***.***> wrote:
@Fang- <https://github.com/Fang-> requested your review on: #1121
<#1121> Add a readme.
—
You are receiving this because your review was requested.
Reply to this email directly, view it on GitHub
<#1121 (comment)>, or mute the
thread
<https://github.com/notifications/unsubscribe-auth/ABiQ4yLFkqptma5pwnyndDSsjC7ThdrEks5vaPkbgaJpZM4cHUZg>
.
|
Contributor
|
This is probably going to need special sync blacklisting similar to
LICENSE.txt, so we don't have an illegal-@ta /=home=/'README'/md? In which
case lack of arvo support should be fine.
…On Monday, 25 March 2019, Fang ***@***.***> wrote:
Comes with usage instructions largely copied from urbit/urbit, minimum
viable developer instructions, minimum viable contributor direction, and
minimum viable flair.
Happy to take suggestions for better copy right now, or punt on that and
merge as is. This will definitely need a rewrite at some point.
Also, how do we want to deal with Arvo's lack of .md support? We'll want
a readme *.md* for Github presentation reasons, right?
------------------------------
You can view, comment on, or merge this pull request online at:
#1121
Commit Summary
- Add a readme
- Add minimal contributing section to readme
File Changes
- *A* README.md <https://github.com/urbit/arvo/pull/1121/files#diff-0>
(64)
Patch Links:
- https://github.com/urbit/arvo/pull/1121.patch
- https://github.com/urbit/arvo/pull/1121.diff
—
You are receiving this because you are subscribed to this thread.
Reply to this email directly, view it on GitHub
<#1121>, or mute the thread
<https://github.com/notifications/unsubscribe-auth/ABxXhiUpr83xvUFoPBSicpHJyOJFh2cPks5vaPkcgaJpZM4cHUZg>
.
|
dpc
approved these changes
Mar 25, 2019
Contributor
|
(Or possibly generic "if a file name is in all caps / not valid knot, don't
sync it", though that seems likely to be confusing and generally produce
"false" positives wrt user expectations) (I guess if there's a "file with
invalid name not synced" printf that migh be fine?)
…On Monday, 25 March 2019, Dawid Ciężarkiewicz ***@***.***> wrote:
***@***.**** approved this pull request.
—
You are receiving this because you commented.
Reply to this email directly, view it on GitHub
<#1121 (review)>, or mute
the thread
<https://github.com/notifications/unsubscribe-auth/ABxXhiFrtiB3axJyreYRFDs29jd4yA8Jks5vaQlsgaJpZM4cHUZg>
.
|
vvisigoth
approved these changes
Mar 26, 2019
Contributor
vvisigoth
left a comment
There was a problem hiding this comment.
APPROVED (complete with reference to tag-based issue system ;p)
Closed
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Comes with usage instructions largely copied from
urbit/urbit, minimum viable developer instructions, minimum viable contributor direction, and minimum viable flair.Happy to take suggestions for better copy right now, or punt on that and merge as is. This will definitely need a rewrite at some point.
Also, how do we want to deal with Arvo's lack of
.mdsupport? We'll want a readme.mdfor Github presentation reasons, right?