Thanks to visit codestin.com
Credit goes to github.com

Skip to content
This repository was archived by the owner on Aug 14, 2019. It is now read-only.

Conversation

@Fang-
Copy link
Contributor

@Fang- Fang- commented May 2, 2019

This now matches the one in zuse.

Seems like something that was missed during single-homing?

Curiously, people who hadn't touched their helm.hoon were still able to rekey just fine. Only after recompiling helm.hoon did they run into problems with this.

(idk where to target this PR anymore)

@Fang- Fang- requested a review from joemfb May 2, 2019 21:28
@Fang- Fang- changed the base branch from master to hotfix May 2, 2019 21:30
@Fang- Fang- changed the base branch from hotfix to master May 2, 2019 21:30
Copy link
Contributor

@joemfb joemfb left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM!

We really need to get $> working so this kind of thing doesn't happen anymore (says the party responsible ...). @jtobin is responsible for branch targeting, merging, &c

@jtobin jtobin merged commit 1323120 into master May 3, 2019
@jtobin jtobin deleted the helm-mint branch May 3, 2019 11:33
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

4 participants