This repository was archived by the owner on Aug 14, 2019. It is now read-only.
remove +hard, replace with new ;; #1166
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Contributor
|
I believe this to be right and proper.
While the equation of type, schema and validator is extremely useful, Postel’s law is much less so — you rarely want to normalize incoming network data, though schema evolution remains a thing. And what the “idempotence” (really fixpoint) test is testing is not the correctness of the data but the correctness of the schema, which really no one needs...
…Sent from my iPhone
On May 9, 2019, at 12:49 PM, pilfer-pandex ***@***.***> wrote:
The previous commit changed the semantics of ;; to just call the mold with the result of the hoon, rather than having it macroexpand to something like hard. By "hard" is meant applying the mold and then checking whether the result is unchanged. This second commit removes the +hard function itself, with the effect that there are no remaining mold "idempotence" tests in the system.
#1055
You can view, comment on, or merge this pull request online at:
#1166
Commit Summary
remove +hard, replace with new ;;
File Changes
M lib/collections.hoon (4)
M lib/hall-legacy.hoon (2)
M lib/hood/kiln.hoon (4)
M lib/oauth1.hoon (3)
M lib/oauth2.hoon (3)
M lib/test/runner.hoon (5)
M mar/collections/action.hoon (4)
M sys/arvo.hoon (20)
M sys/hoon.hoon (35)
M sys/vane/ames.hoon (12)
M sys/vane/behn.hoon (2)
M sys/vane/clay.hoon (67)
M sys/vane/dill.hoon (4)
M sys/vane/eyre.hoon (12)
M sys/vane/ford.hoon (6)
M sys/vane/gall.hoon (6)
M sys/vane/jael.hoon (2)
M sys/vane/xmas.hoon (8)
M sys/zuse.hoon (8)
Patch Links:
https://github.com/urbit/arvo/pull/1166.patch
https://github.com/urbit/arvo/pull/1166.diff
—
You are receiving this because you are subscribed to this thread.
Reply to this email directly, view it on GitHub, or mute the thread.
|
joemfb
suggested changes
May 9, 2019
Contributor
joemfb
left a comment
There was a problem hiding this comment.
It looks like there's still a call in lib/hall-legacy. Otherwise, this LGTM
Contributor
Author
|
You're right. My test procedure was a combo of |reset and +test, which did not catch this. What testing strategies do you use? |
pilfer-pandex
commented
May 9, 2019
lib/hall-legacy.hoon
Outdated
| name+(ot nom+so mon+tors ~) | ||
| text+(cu to-wain:format so) | ||
| tank+(ot dat+(cu (hard (list tank)) blob) ~) | ||
| tank+(ot dat+(cu ;;((list tank) blob)) ~) |
Contributor
Author
There was a problem hiding this comment.
Not a call to hard, but still wrong.
joemfb
approved these changes
May 9, 2019
jtobin
approved these changes
May 10, 2019
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
The previous commit changed the semantics of ;; to just call the mold with the result of the hoon, rather than having it macroexpand to something like hard. By "hard" is meant applying the mold and then checking whether the result is unchanged. This second commit removes the +hard function itself, with the effect that there are no remaining mold "idempotence" tests in the system.
#1055