fix +sloe for %hint'ed cores #2764
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
pilfer-pandex
approved these changes
Apr 22, 2020
jtobin
pushed a commit
that referenced
this pull request
Apr 23, 2020
* ted/sloe: pill: update solid fix +sloe for %hint'ed cores Signed-off-by: Jared Tobin <[email protected]>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
+sloe, which lists the arms of a core type, was broken for core types wrapped in a%hinttag, producing~as though the core had no arms. This fix unwraps the%hintusing+repo:ut, like everything else.I think this bug arose because
%hintwas added later, and there was no type error because it was wildcard-matched with a?+. I hope this is the only such case!