publish-fe: Adds deletion and editing of comments #2734
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Adds interface affordances for the addition and removal of comments.
the root container had height: 100% but also a margin-top set on it. This caused unnecessary scrollbars to appear when the content did not actually overflow the container.
An incorrect check caused comment editing to never be propagated.
|
cc: @ixv |
|
Cancel should definitely be beside the "Submit" button as a Edit as green text looks odd, but I did that the first time (with the Publish header matter, ha) and I have no counter-suggestions. |
|
|
|
Are there dark mode styles on that?
…Sent from my iPhone
On Apr 14, 2020, at 9:04 PM, Liam Fitzgerald ***@***.***> wrote:
—
You are receiving this because you were mentioned.
Reply to this email directly, view it on GitHub, or unsubscribe.
|
|
yuh |
|
Matilde caught everything here, final results are looking good. |
|
ping @ixv |
|
I hit a bug where after editing one comment, another comment was deleted. Trying to get a repro now. |
ixv
approved these changes
Apr 17, 2020
|
@ixv I hit a bug last night where after attempting to edit a post (which resulted in a silent failure), I tried to add a comment. When I clicked the button to submit the comment, it took me back to a different page, but it seems to have swallowed the comment. It did this twice in a row. |
Closed
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
6 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Adds interface affordances for the addition and removal of comments.
drafted rn because clay doesn't appear to like the publish-comment mark for whatever reason. Have filed a bug in #2731 . Deletion works fine, but updates are a no go (may actually bork your entire fakezod).
cc: @matildepark @urcades
Demo:
